public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: airlied@redhat.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] char/agp: remove agp_bridge_data::type
Date: Fri, 16 Feb 2024 18:07:36 +0100	[thread overview]
Message-ID: <Zc-WWH8_UNBCOlri@phenom.ffwll.local> (raw)
In-Reply-To: <20240213111511.25187-1-jirislaby@kernel.org>

On Tue, Feb 13, 2024 at 12:15:11PM +0100, Jiri Slaby (SUSE) wrote:
> agp_bridge_data::type is unused (and I cannot find when was used last).
> 
> Therefore, remove it.
> 
> Found by https://github.com/jirislaby/clang-struct.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: David Airlie <airlied@redhat.com>
> Cc: dri-devel@lists.freedesktop.org

Thanks, pushed to drm-misc-next.
-Sima

> ---
>  drivers/char/agp/agp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h
> index 5c36ab85f80b..67d7be800a7c 100644
> --- a/drivers/char/agp/agp.h
> +++ b/drivers/char/agp/agp.h
> @@ -138,7 +138,6 @@ struct agp_bridge_data {
>  	unsigned long gart_bus_addr;
>  	unsigned long gatt_bus_addr;
>  	u32 mode;
> -	enum chipset_type type;
>  	unsigned long *key_list;
>  	atomic_t current_memory_agp;
>  	atomic_t agp_in_use;
> -- 
> 2.43.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

      reply	other threads:[~2024-02-16 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13 11:15 [PATCH] char/agp: remove agp_bridge_data::type Jiri Slaby (SUSE)
2024-02-16 17:07 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zc-WWH8_UNBCOlri@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox