From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>
Subject: Re: [PATCH v2 2/3] auxdisplay: Move cfag12864b.h to the subsystem folder
Date: Wed, 14 Feb 2024 20:54:02 +0200 [thread overview]
Message-ID: <Zc0MShdvTsjrGGjl@smile.fi.intel.com> (raw)
In-Reply-To: <CANiq72mYMztZG5Y5v6m+h2xroDFyyf0Kn7aZ2D7p6p4k_YtTcw@mail.gmail.com>
On Wed, Feb 14, 2024 at 07:48:31PM +0100, Miguel Ojeda wrote:
> On Wed, Feb 14, 2024 at 6:50 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > It's a standard practice in the Linux kernel development.
> > If it's not a so critical issue, why should we rebase?
> >
> > rebasing will break SHA sums and it's not appreciated especially at the late
> > rcX weeks. Linus can even refuse to accept a PR based on this fact.
>
> I am well aware of what rebasing does and the rules for PRs to Linus, thank you.
>
> First of all, you should have not applied the patch this quickly.
> Nobody gave a tag for it and you yourself are the author. Even if
> someone gave you a tag, 2 days is way too little time for something
> like auxdisplay. 2 weeks would be a more reasonable time frame.
>
> The point is: you seem to be rejecting feedback on the basis that you
> already applied a patch that you yourself authored 2 days ago. Not
> good.
>
> Now, for branches in linux-next, what you should avoid is rebasing
> wildly, but you can still do so if needed. If you are uncomfortable
> with that, then you should avoid rushing patches to begin with so that
> you don't have to do that.
>
> Regarding PRs to Linus, we are still in -rc4. There is plenty of time
> to bake things in `linux-next`. Unless you meant to sent this to a -rc
> release. But in that case: 1) there is no rush, 2) please see the
> first point again.
Okay, I dropped that patch from the queue.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-14 18:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 13:23 [PATCH v2 0/3] auxdisplay: Refresh MAINTAINERS for the subsystem Andy Shevchenko
2024-02-12 13:23 ` [PATCH v2 1/3] auxdisplay: Take over maintainership, but in Odd Fixes mode Andy Shevchenko
2024-02-12 13:36 ` Andy Shevchenko
2024-02-12 13:43 ` Geert Uytterhoeven
2024-02-12 13:46 ` Andy Shevchenko
2024-02-12 16:33 ` Thomas Zimmermann
2024-02-12 16:42 ` Andy Shevchenko
2024-02-12 16:43 ` Andy Shevchenko
2024-02-13 8:10 ` Javier Martinez Canillas
2024-02-13 12:11 ` Miguel Ojeda
2024-02-13 14:55 ` Andy Shevchenko
2024-02-13 8:28 ` Thomas Zimmermann
2024-02-13 8:34 ` Geert Uytterhoeven
2024-02-12 22:33 ` Miguel Ojeda
2024-02-12 13:23 ` [PATCH v2 2/3] auxdisplay: Move cfag12864b.h to the subsystem folder Andy Shevchenko
2024-02-12 13:36 ` Andy Shevchenko
2024-02-14 16:58 ` Geert Uytterhoeven
2024-02-14 17:15 ` Miguel Ojeda
2024-02-14 17:40 ` Andy Shevchenko
2024-02-14 17:42 ` Miguel Ojeda
2024-02-14 17:50 ` Andy Shevchenko
2024-02-14 18:48 ` Geert Uytterhoeven
2024-02-14 18:48 ` Miguel Ojeda
2024-02-14 18:54 ` Andy Shevchenko [this message]
2024-02-14 18:57 ` Andy Shevchenko
2024-02-12 13:23 ` [PATCH v2 3/3] auxdisplay: Add 7 and 14 segment mappings to MAINTAINERS Andy Shevchenko
2024-02-14 17:00 ` Geert Uytterhoeven
2024-02-12 13:37 ` [PATCH v2 0/3] auxdisplay: Refresh MAINTAINERS for the subsystem Andy Shevchenko
2024-02-13 16:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc0MShdvTsjrGGjl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox