From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE7FF1292F4; Fri, 16 Feb 2024 15:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708096129; cv=none; b=eXGl7BwbvVv5/xzB8RUxf2YrEyMLXLu5tvwg8BBJgD7T8ug7nemyR8AunT3StClECHtUBav1gJMEayX6WRwuOhfG1Nk6CYTfp/R75XcWvs/bpq2NPX87Z2IQtJpkPlgNU+eYqmhvvAsm1DMPfUzzauqKe2GKs+fIO96W4aI3n24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708096129; c=relaxed/simple; bh=AOCAORj/NLMv+eKT0QBmdsr53HgKAYcc7MKJyrnstS4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eG6DcpN9WmjNgRfhaCLTzq3OKykmXQ27KdZQ754lTGCIq6EQWAWD0z7EMS81dYcvFII2P+7Vav6mhTZa7aUSaEXOM/QPFia5bnUEaBz8lfXhlCmXBDkAmrJdiESMNT8AJqbbz7UJbbmlInbjdCVKf5o0bH7z6lei95YkkS7NItk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="2338378" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="2338378" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2024 07:08:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="912374432" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="912374432" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2024 07:08:40 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1razpN-000000054tL-1WLs; Fri, 16 Feb 2024 17:08:37 +0200 Date: Fri, 16 Feb 2024 17:08:37 +0200 From: Andy Shevchenko To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 02/18] pinctrl: pinctrl-single: remove dead code in suspend() and resume() callbacks Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-2-5c2e4a3fac1f@bootlin.com> <78add459-a96a-46c6-83ff-e2657d4d3db4@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78add459-a96a-46c6-83ff-e2657d4d3db4@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Feb 16, 2024 at 08:59:47AM +0100, Thomas Richard wrote: > On 2/15/24 16:27, Andy Shevchenko wrote: > > On Thu, Feb 15, 2024 at 04:17:47PM +0100, Thomas Richard wrote: > >> No need to check the pointer returned by platform_get_drvdata(), as > >> platform_set_drvdata() is called during the probe. > > > > This patch should go _after_ the next one, otherwise the commit message doesn't > > tell full story and the code change bring a potential regression. > > Hello Andy, > > I'm ok to move this patch after the next one. > But for my understanding, could you explain me why changing the order is > important in this case ? Old PM calls obviously can be called in different circumstances and these checks are important. Just squash these two patches to avoid additional churn and we are done. -- With Best Regards, Andy Shevchenko