From: Andy Shevchenko <andy@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
Justin Stitt <justinstitt@google.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Wang <jasowang@redhat.com>,
kernel test robot <lkp@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Azeem Shaikh <azeemshaikh38@gmail.com>,
linux-kernel@vger.kernel.org, linux-um@lists.infradead.org
Subject: Re: [PATCH v2 3/4] string: Allow 2-argument strscpy_pad()
Date: Mon, 5 Feb 2024 14:57:06 +0200 [thread overview]
Message-ID: <ZcDbIleAJcipUk5E@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdXnW0ycz4y0m6d2yb_cAB4pjLmpveVBnL4sLNATtm388A@mail.gmail.com>
On Mon, Feb 05, 2024 at 01:48:51PM +0100, Geert Uytterhoeven wrote:
> On Mon, Feb 5, 2024 at 1:36 PM Kees Cook <keescook@chromium.org> wrote:
...
> > +#define __strscpy_pad1(dst, src, size) sized_strscpy_pad(dst, src, size)
>
> (dst) etc.
Makes a little sense here. Are you expecting, e.g., dst to be 'a, b' (w/o
quotes where a and b are expressions)?
...
> > +#define strscpy_pad(dst, src, ...) \
> > + CONCATENATE(__strscpy_pad, COUNT_ARGS(__VA_ARGS__))(dst, src, __VA_ARGS__)
>
> Likewise,
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-05 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 12:35 [PATCH v2 0/4] string: Allow 2-argument strscpy() Kees Cook
2024-02-05 12:35 ` [PATCH v2 1/4] string: Redefine strscpy_pad() as a macro Kees Cook
2024-02-05 12:35 ` [PATCH v2 2/4] string: Allow 2-argument strscpy() Kees Cook
2024-02-05 12:47 ` Geert Uytterhoeven
2024-02-05 12:58 ` Andy Shevchenko
2024-02-05 13:01 ` Kees Cook
2024-02-05 13:07 ` Geert Uytterhoeven
2024-02-05 12:35 ` [PATCH v2 3/4] string: Allow 2-argument strscpy_pad() Kees Cook
2024-02-05 12:48 ` Geert Uytterhoeven
2024-02-05 12:57 ` Andy Shevchenko [this message]
2024-02-05 12:35 ` [PATCH v2 4/4] um: Convert strscpy() usage to 2-argument style Kees Cook
2024-02-05 12:50 ` Geert Uytterhoeven
2024-02-05 12:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcDbIleAJcipUk5E@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=azeemshaikh38@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jasowang@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=lkp@intel.com \
--cc=nathan@kernel.org \
--cc=richard@nod.at \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox