From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: Jens Taprogge <jens.taprogge@taprogge.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
industrypack-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipack: make ipack_bus_type const
Date: Mon, 5 Feb 2024 15:41:52 +0100 [thread overview]
Message-ID: <ZcDzsP8mRl3Rp9bx@gmail.com> (raw)
In-Reply-To: <20240204-bus_cleanup-ipack-v1-1-aef5e8f84d01@marliere.net>
On Sun, Feb 04, 2024 at 05:00:13PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the ipack_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
> drivers/ipack/ipack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
> index b1471ba016a5..866bf48d803b 100644
> --- a/drivers/ipack/ipack.c
> +++ b/drivers/ipack/ipack.c
> @@ -187,7 +187,7 @@ static struct attribute *ipack_attrs[] = {
> };
> ATTRIBUTE_GROUPS(ipack);
>
> -static struct bus_type ipack_bus_type = {
> +static const struct bus_type ipack_bus_type = {
> .name = "ipack",
> .probe = ipack_bus_probe,
> .match = ipack_bus_match,
>
> ---
> base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
> change-id: 20240204-bus_cleanup-ipack-7e502021db1f
>
> Best regards,
> --
> Ricardo B. Marliere <ricardo@marliere.net>
>
Hello Ricardo,
Thank you for your patch.
Acked-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Greg, would you please add it to your misc tree.
Thanks and regards,
Vaibhav Gupta
next prev parent reply other threads:[~2024-02-05 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 20:00 [PATCH] ipack: make ipack_bus_type const Ricardo B. Marliere
2024-02-05 14:41 ` Vaibhav Gupta [this message]
2024-02-05 19:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcDzsP8mRl3Rp9bx@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo@marliere.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox