From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Zhiguo Niu <zhiguo.niu@unisoc.com>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, niuzhiguo84@gmail.com,
ke.wang@unisoc.com, hongyu.jin@unisoc.com
Subject: Re: [PATCH 0/3] f2fs: fix panic issue in small capacity device
Date: Mon, 5 Feb 2024 19:15:50 -0800 [thread overview]
Message-ID: <ZcGkZslfFLP8wqUr@google.com> (raw)
In-Reply-To: <1706523684-24540-1-git-send-email-zhiguo.niu@unisoc.com>
On 01/29, Zhiguo Niu wrote:
> A panic issue happened in a reboot test in small capacity device
> as following:
> 1.The device size is 64MB, and main area has 24 segments, and
> CONFIG_F2FS_CHECK_FS is not enabled.
> 2.There is no any free segments left shown in free_segmap_info,
> then another write request cause get_new_segment get a out-of-bound
> segment with segno 24.
> 3.panic happen in update_sit_entry because access invalid bitmap
> pointer.
The goal here is to stop f2fs when it hits no space to write anymore?
And, we need f2fs_stop_checkpoint() at the end?
>
> More detail shown in following three patches.
> The three patches are splited here because the modifications are
> relatively independent and more readable.
>
> Zhiguo Niu (3):
> f2fs: correct counting methods of free_segments in __set_inuse
> f2fs: fix panic issue in update_sit_entry
> f2fs: enhance judgment conditions of GET_SEGNO
>
> fs/f2fs/file.c | 7 ++++++-
> fs/f2fs/segment.c | 9 ++++++---
> fs/f2fs/segment.h | 7 ++++---
> 3 files changed, 16 insertions(+), 7 deletions(-)
>
> --
> 1.9.1
next prev parent reply other threads:[~2024-02-06 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 10:21 [PATCH 0/3] f2fs: fix panic issue in small capacity device Zhiguo Niu
2024-02-06 3:15 ` Jaegeuk Kim [this message]
2024-02-06 5:58 ` Zhiguo Niu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcGkZslfFLP8wqUr@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=hongyu.jin@unisoc.com \
--cc=ke.wang@unisoc.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox