From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jonathan Denose <jdenose@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
jefferymiller@google.com, Jonathan Denose <jdenose@google.com>,
Raul Rangel <rrangel@chromium.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: psmouse - add resync_on_resume dmi check
Date: Tue, 6 Feb 2024 14:04:23 -0800 [thread overview]
Message-ID: <ZcKs589qYxviC1J4@google.com> (raw)
In-Reply-To: <20231102075243.1.Idb37ff8043a29f607beab6440c32b9ae52525825@changeid>
Hi Jonathan,
On Thu, Nov 02, 2023 at 07:52:47AM -0500, Jonathan Denose wrote:
> Some elantech touchpads consistently fail after resuming from
> suspend at sanity_check in elantech_packet_check_v4. This means
> the touchpad is completely unusable after suspend resume.
>
> With different permutations of i8042 nomux, nopnp, reset, and noloop
> kernel options enabled, and with crc_enabled the touchpad fails in
> the same way.
>
> Resyncing the touchpad after receiving the
> PACKET_UNKNOWN/PSMOUSE_BAD_DATA return code allows the touchpad to
> function correctly on resume. The touchpad fails to reconnect with
> the serio reconnect no matter how many times it retries, so this
> change skips over that retry sequence and goes directly to resync.
Why can't we do this in elantech_reconnect()? I am sure we can make it
simpler and more robust than what the generic handler is trying to do
with polling and everything.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-02-06 22:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 12:52 [PATCH] Input: psmouse - add resync_on_resume dmi check Jonathan Denose
2024-02-06 22:04 ` Dmitry Torokhov [this message]
2024-02-07 16:39 ` Jonathan Denose
2024-02-09 19:01 ` Dmitry Torokhov
2024-02-12 20:57 ` Jonathan Denose
2024-02-29 18:23 ` Dmitry Torokhov
2024-03-04 17:17 ` Jonathan Denose
2024-03-05 18:47 ` Dmitry Torokhov
2024-03-05 21:48 ` Jonathan Denose
2024-03-05 23:17 ` Dmitry Torokhov
2024-03-06 16:43 ` Jonathan Denose
2024-03-07 18:29 ` Dmitry Torokhov
2024-08-05 14:18 ` Hans de Goede
2024-08-05 16:52 ` Dmitry Torokhov
2024-08-09 15:35 ` Jonathan Denose
2024-08-10 12:59 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcKs589qYxviC1J4@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=jdenose@chromium.org \
--cc=jdenose@google.com \
--cc=jefferymiller@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox