Re: [PATCH v2 2/2] phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver

Vinod Koul
2024-02-07T14:06:41Z

On 07-02-24, 14:39, Cristian Ciocaltea wrote:
> On 2/7/24 12:16, Vinod Koul wrote:
> > On 05-02-24, 13:24, Cristian Ciocaltea wrote:

> >> +static u8 hdptx_grf_read(struct rockchip_hdptx_phy *hdptx, u32 reg)
> >> +{
> >> + u32 val;
> >> +
> >> + regmap_read(hdptx->grf, reg, &val);
> >> +
> >> + return val;
> >> +}
> >
> > why use wrappers, why not call regmap_ apis directly
>
> Agree, no real benefit, will drop them, except probably
> hdptx_multi_reg_write() for the extra savings.

That one is fine as there is good logic on the helper

> So I'd keep using that one if there's no strong reason against.

ok

--
~Vinod