[RFC PATCH 6/8] cgroup/cpuset: Enable dynamic rcu_nocb mode on isolated CPUs

Waiman Long
2024-01-17T16:36:19Z

The patch adds RCU no-callback isolation mode dynamically to isolated
CPUs within isolated partitions when the full CPU isolation mode is
enabled. This isolation feature will only be available for use by cpuset
if the "rcu_nocb" boot command line option is specified in the kernel
command line with or without the optional CPU list argument.

Signed-off-by: Waiman Long <longman@redhat.com>
---
kernel/cgroup/cpuset.c | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index d1d4ce213979..40bbb0a9cb84 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -218,6 +218,11 @@ enum isolated_cpus_modifiers {
*/
static cpumask_var_t isolated_cpus;

+/*
+ * rcu_nocb_mask set up at boot time.
+ */
+static cpumask_var_t rcu_nocb_mask_preset;
+
/*
* Enable full CPU isolation in isolated partitions, if set.
*/
@@ -229,15 +234,26 @@ static bool isolation_full;
static int isolation_flags;

enum cpuset_isolation_types {
+ ISOL_TYPE_RCU, /* RCU no-callback CPU mode */
ISOL_TYPE_MAX,
};

+enum cpuset_isolation_flags {
+ ISOL_FLAG_RCU = BIT(ISOL_TYPE_RCU),
+};
+
static const char * const isolation_type_names[ISOL_TYPE_MAX] = {
+ [ISOL_TYPE_RCU] = "rcu_nocbs",
};

/* Detect the cpuset isolation modes that can be enabled */
static __init int set_isolation_flags(void)
{
+ if (rcu_nocb_enabled(NULL)) {
+ BUG_ON(!zalloc_cpumask_var(&rcu_nocb_mask_preset, GFP_KERNEL));
+ (void)rcu_nocb_enabled(rcu_nocb_mask_preset);
+ isolation_flags |= ISOL_FLAG_RCU;
+ }
return 0;
}
late_initcall(set_isolation_flags);
@@ -1554,6 +1570,7 @@ static int partition_xcpus_del(int old_prs, struct cpuset *parent,
static int update_isolation_cpumasks(struct cpumask *mask, int modifier)
{
int err;
+ bool enable = (modifier == ISOL_CPUS_ADD);

lockdep_assert_cpus_held();

@@ -1569,6 +1586,25 @@ static int update_isolation_cpumasks(struct cpumask *mask, int modifier)
if (WARN_ON_ONCE(cpumask_empty(mask)))
return -EINVAL;

+ err = 0;
+ if (isolation_flags & ISOL_FLAG_RCU) {
+ /*
+ * When disabling rcu_nocb, make sure that we don't touch any
+ * CPUs that have already been set in rcu_nocb_mask_preset.
+ */
+ if (!enable && cpumask_intersects(mask, rcu_nocb_mask_preset)) {
+ cpumask_var_t tmp_mask;
+
+ if (WARN_ON_ONCE(!alloc_cpumask_var(&tmp_mask, GFP_KERNEL)))
+ return -ENOMEM;
+ if (cpumask_andnot(tmp_mask, mask, rcu_nocb_mask_preset))
+ err = rcu_nocb_cpumask_update(tmp_mask, enable);
+ free_cpumask_var(tmp_mask);
+ } else {
+ err = rcu_nocb_cpumask_update(mask, enable);
+ }
+ }
+ WARN_ON_ONCE(err);
return err;
}

--
2.39.3