From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA56D7F472 for ; Wed, 7 Feb 2024 14:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707317907; cv=none; b=DoRGxGtOTJyO3MHkjhdCdQo/iue+QOXjR+MsU14Rsc2bJNiLtazlTGzuoURkhujralcoLiwYlWKGgv5EORqzYTz09WdyeLHpwjNeS+3IedbtG5crZW1Vk++qy/+2kZQGrRCNmWlff4P0T5MfxrZAxPDJikt/9ZtAJDbHz1cMNpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707317907; c=relaxed/simple; bh=fHxvY9j/1axe2y2RH+QTdN9Fl0eA2wK3G26jE5p972U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=P5srkdj4MnoR7HT7/H9IPbEShLqHwtWoDcogkswdn5s4m85UUtK+7Os5ssw3sY4NzEupfHnfA7fty2Od11+Ua9SIxW1CT//DX4bfkuylX4X/IxxNTJviv8aafSYrD/Z0Qm003ZWoebg/INamsZbigABJ3jZh1oy4HA05QPNI1dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SU6HsbBY; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SU6HsbBY" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc6cd10fd94so1028094276.3 for ; Wed, 07 Feb 2024 06:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707317905; x=1707922705; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=022zwx6MCTM2+vKlsZn6bQvDtEHFbRDoI918KeNrDZQ=; b=SU6HsbBYACKfMQSVt4o3Eljxgs78Ny9XAxR4wt3KTJXvwLFsdo/j0wJymr6fZMCwSa G50doHOSltLcdCGrISd/TSpCWQMZNd92wmRQ+GTIBzxiHwr//oKccmIbcOWgsVDry/l1 SoiOlcIKtEChrfTju7iV5QZpNeZFJWpKQ7/xqG/06ljUK+mIMntbM9ti2jND4LQT551c 0ExrMd+hxNu+DcyWSblFxjaTxQ03WFJzsR4AF87n7IOoT2xdioEIi0eoTDmy4FGJGDk5 M0ccaTWx2FiAiIpi4feptu+wZTyEFnEl7Zt67EQylGuMnUac/U3Kkm97pgtSuPUQl4+w 4gwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707317905; x=1707922705; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=022zwx6MCTM2+vKlsZn6bQvDtEHFbRDoI918KeNrDZQ=; b=Dafx1P97XczkJIKvRvoeuqFS7ZKuwbUORb96gfmYxoGZQ508qgWCHyFCgNgiOkMk9i emmaKKt9YniiBmeZff3OA1RWkPfrydhOjKbj4MiySIlTRxji7aQMRsPWG1RiJBYXbEuO 8p21lTChUqxg3ZNBfHJGmCHriA4ZH6RYfm1adTK39G3EkA+XDevtVTuzoP8jcYTVRkKr pvSReeQTHjzoTAIiPhk09Sjg0tctJD5PFPvIMybjICuC0KiRsOlwID+2jcywdBwGCRZt dOSJ6DDYaxvgMbM/hMTOkowVtM40baW9sjH9QY+umlASD3jPwZvt9G/pBl0Y+iv09oeT vX5A== X-Gm-Message-State: AOJu0YzS7W93CcFhFPMTtYbut/Im8WrAOYkHPfxuynrMP1dbD2jbZi2e CADuilwU7CJj0vh2273kLc2SwMay5RbG2w/ccp44/nSamP16JY0Ib98/NT86Y1EW4v9LmI2AGpC ooA== X-Google-Smtp-Source: AGHT+IH8cjw7WA+9nGuzcgqW2xA8Iv7w9A4Dc0/I3ut6wcjH4wqie1YwlqkB90ZuGDFt+lLgxUp28nS+SV8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:11c9:b0:dc6:dfd9:d431 with SMTP id n9-20020a05690211c900b00dc6dfd9d431mr1230159ybu.1.1707317905016; Wed, 07 Feb 2024 06:58:25 -0800 (PST) Date: Wed, 7 Feb 2024 06:58:22 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240115125707.1183-1-paul@xen.org> <20240115125707.1183-14-paul@xen.org> Message-ID: Subject: Re: [PATCH v12 13/20] KVM: selftests / xen: map shared_info using HVA rather than GFN From: Sean Christopherson To: paul@xen.org Cc: Paolo Bonzini , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , David Woodhouse , Shuah Khan , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Wed, Feb 07, 2024, Paul Durrant wrote: > On 07/02/2024 04:14, Sean Christopherson wrote: > > Please stop making up random scopes. Yes, I know "KVM: selftests:" is too coarse, > > bt everyone doing their own thing is worse. > > So what would you suggest? Until someone comes up with a better idea that at least a majority of developers agree on, maintain the status quo and use "KVM: selftests:" for the scope, and call out and/or allude to the relevant test(s) in the shortlog. E.g. you can even squeeze in both: KVM: selftests: Map Xen's shared_info page by HVA, not GPA in xen_shinfo_test I know it's kludgy and silly, but it's consistent. Aside from consistency, the "problem" with selftests is that most changes are either specific to one test, or affect multiple tests that have no common denominator beyond KVM. And for changes that are targeted at a single test, I find it helpful if the shortlog specifies the exact test that's being changed. To be clear, I am definitely open to ideas if people feel "KVM: selftests" isn't working, I just want us to make a decision as a group and commit to it, as opposed to people using whatever scope suits their fancy.