From: Charlie Jenkins <charlie@rivosinc.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
David Laight <David.Laight@aculab.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v6 0/2] lib: checksum: Fix issues with checksum tests
Date: Wed, 7 Feb 2024 18:09:53 -0800 [thread overview]
Message-ID: <ZcQ38U20MLSdIxHP@ghost> (raw)
In-Reply-To: <20240207174522.2d19729ec2e014d521335a04@linux-foundation.org>
On Wed, Feb 07, 2024 at 05:45:22PM -0800, Andrew Morton wrote:
> On Wed, 07 Feb 2024 16:22:49 -0800 Charlie Jenkins <charlie@rivosinc.com> wrote:
>
> > The ip_fast_csum and csum_ipv6_magic tests did not have the data
> > types properly casted, and improperly misaligned data.
>
> Neither this nor the two patch's changelogs describe *why* these changes
> are needed. They merely assert that we need to do this.
>
> IOW, when fixing a bug please always describe the user-visible effects
> of that bug.
>
I can add a description that says that the tests are being fixed because
they caused failures on systems without misaligned access support. As
for the casting patch it's a bit less pertinent but I can add that it
allows the code to pass sparse checks.
- Charlie
next prev parent reply other threads:[~2024-02-08 2:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 0:22 [PATCH v6 0/2] lib: checksum: Fix issues with checksum tests Charlie Jenkins
2024-02-08 0:22 ` [PATCH v6 1/2] lib: checksum: Fix type casting in checksum kunits Charlie Jenkins
2024-02-08 0:22 ` [PATCH v6 2/2] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests Charlie Jenkins
2024-02-08 2:45 ` Guenter Roeck
2024-02-12 6:26 ` Al Viro
2024-02-12 17:18 ` Guenter Roeck
2024-02-12 18:09 ` Charlie Jenkins
2024-02-12 18:26 ` Guenter Roeck
2024-02-12 18:12 ` Al Viro
2024-02-12 18:34 ` Guenter Roeck
2024-02-12 18:41 ` Charlie Jenkins
2024-02-12 18:43 ` Al Viro
2024-02-08 1:45 ` [PATCH v6 0/2] lib: checksum: Fix issues with checksum tests Andrew Morton
2024-02-08 2:09 ` Charlie Jenkins [this message]
2024-02-08 2:44 ` Guenter Roeck
2024-02-08 2:47 ` Palmer Dabbelt
2024-02-08 4:15 ` Guenter Roeck
2024-02-11 19:18 ` Guenter Roeck
2024-02-12 5:26 ` Charlie Jenkins
2024-02-12 17:10 ` Guenter Roeck
2024-02-16 9:01 ` Geert Uytterhoeven
2024-02-12 12:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcQ38U20MLSdIxHP@ghost \
--to=charlie@rivosinc.com \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox