Re: [PATCH v7 00/14] Add support for the Mobileye EyeQ5 SoC

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Mon, Feb 05, 2024 at 04:34:46PM +0100, Gregory CLEMENT wrote:
> Hello,
> 
> The EyeQ5 SoC from Mobileye is based on the MIPS I6500 architecture
> and features multiple controllers such as the classic UART, I2C, SPI,
> as well as CAN-FD, PCIe, Octal/Quad SPI Flash interface, Gigabit
> Ethernet, MIPI CSI-2, and eMMC 5.1. It also includes a Hardware
> Security Module, Functional Safety Hardware, and MJPEG encoder.
> 
> One peculiarity of this SoC is that the physical address of the DDDR
> exceeds 32 bits. Given that the architecture is 64 bits, this is not
> an issue, but it requires some changes in how the mips64 is currently
> managed during boot.
> 
> In this seventh version, I removed the OLB related part as it is not
> used yet. I have left it to Théo to handle in his series. Another
> notable change is the Kconfig modification to remove the selection of
> unused configurations.
> [..]

thank you for your work on this patch set. I've commented on the
two patches, where is see need for changes. Other than that it's
looking good.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]