Re: [PATCH] Input: psmouse - add resync_on_resume dmi check

Dmitry Torokhov
2024-02-06T22:04:27Z

Hi Jonathan,

On Thu, Nov 02, 2023 at 07:52:47AM -0500, Jonathan Denose wrote:
> Some elantech touchpads consistently fail after resuming from
> suspend at sanity_check in elantech_packet_check_v4. This means
> the touchpad is completely unusable after suspend resume.
>
> With different permutations of i8042 nomux, nopnp, reset, and noloop
> kernel options enabled, and with crc_enabled the touchpad fails in
> the same way.
>
> Resyncing the touchpad after receiving the
> PACKET_UNKNOWN/PSMOUSE_BAD_DATA return code allows the touchpad to
> function correctly on resume. The touchpad fails to reconnect with
> the serio reconnect no matter how many times it retries, so this
> change skips over that retry sequence and goes directly to resync.

Why can't we do this in elantech_reconnect()? I am sure we can make it
simpler and more robust than what the generic handler is trying to do
with polling and everything.

Thanks.

--
Dmitry