From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D64A364C7; Sat, 10 Feb 2024 10:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707561012; cv=none; b=Pb8Q2Am0ajIhxHtP2n1qR7edDka+jD0SvelBANk9GhRlvClzlIdx38G2wQAdQUJLlwYS+Z4rfTh6gsWfpeP5YY5lyMzC1nL61o3iZc0KXemV4q3noqpMs7V5gnf1npLBhOkx8EZ9AjvPltUGi86/Zr34URnS03ihGlrDcQc5y58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707561012; c=relaxed/simple; bh=A3ud78No7kD0Dn1wHTcneyRE+SVmCuqOLRHwIx5bJeE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UDryS4xgtan2kzS2fIDZCadmK9a1YmfXa9Aaxam26VNC6fVf1zo5TsUOpSurzr9Adv2YmXMWAxpxNfqZpPahxw+kLlJtwkVVg962D1bm61ITmnlISAEAGLss7MXc3ZDqJljn2Rci3AEPOUpMcwTgelv8BssCiSPIV8AgWwlBDjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=T/mPfRyu; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="T/mPfRyu" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ph4jzB86nHaGBdGyQlHwPpxZccThyM3+Io4W8gZIxGI=; b=T/mPfRyuRFUl8GCt02nw5hF8m8 Awp1djpMFwBhecelf0XDJm5aDEs/HFqx7756B0bVepr/IJfGnj/mDwY2ntorwNMhuX7PNwkVwgiOs Vo0wg1FUKUe1QsAW95tmiDTM0/WP/VecHW4kPFzjiebWPfx/akDPQAN9lTy2Xp/2xXX+IbY8KnVwk MgbJRMZIRSjH+kI3aucCRbMHAnW4kOdZf765ego1yIRs35nz7bEpVbQLqzKKnVgwsNeRfkoMwTEpr nQVW3vHN/FJOwHxxSdheb5jdA9FltDBf0iVdtYybDa44bHMN/9CrHW6PvlCMexy63eQf+bCpkOJr8 eiPfQRGA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38040) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rYkbe-0006qq-0m; Sat, 10 Feb 2024 10:29:10 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rYkbU-0007Ja-Ln; Sat, 10 Feb 2024 10:29:00 +0000 Date: Sat, 10 Feb 2024 10:29:00 +0000 From: "Russell King (Oracle)" To: Zhang Bingwu Cc: Catalin Marinas , Will Deacon , Geert Uytterhoeven , Dinh Nguyen , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Zhang Bingwu , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH 1/2] kbuild: Abort make on install failures Message-ID: References: <20240210074601.5363-1-xtex@envs.net> <20240210074601.5363-2-xtex@envs.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240210074601.5363-2-xtex@envs.net> Sender: Russell King (Oracle) On Sat, Feb 10, 2024 at 03:46:00PM +0800, Zhang Bingwu wrote: > From: Zhang Bingwu > > Setting '-e' flag tells shells to exit with error exit code immediately > after any of commands fails, and causes make(1) to regard recipes as > failed. > > Before this, make will still continue to succeed even after the > installation failed, for example, for insufficient permission or > directory does not exist. > > Signed-off-by: Zhang Bingwu > --- > arch/arm/boot/install.sh | 2 ++ > arch/arm64/boot/install.sh | 2 ++ > arch/m68k/install.sh | 2 ++ > arch/nios2/boot/install.sh | 2 ++ > arch/parisc/install.sh | 2 ++ > arch/riscv/boot/install.sh | 2 ++ > arch/s390/boot/install.sh | 2 ++ > arch/sparc/boot/install.sh | 2 ++ > arch/x86/boot/install.sh | 2 ++ > 9 files changed, 18 insertions(+) > > diff --git a/arch/arm/boot/install.sh b/arch/arm/boot/install.sh > index 9ec11fac7d8d..34e2c6e31fd1 100755 > --- a/arch/arm/boot/install.sh > +++ b/arch/arm/boot/install.sh > @@ -17,6 +17,8 @@ > # $3 - kernel map file > # $4 - default install path (blank if root directory) > > +set -e > + What about #!/bin/sh -e on the first line, which is the more normal way to do this for an entire script? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!