From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Peter Zijlstra" <peterz@infradead.org>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"Sumera Priyadarsini" <sylphrenadin@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
linux-acpi@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 0/8] of: automate of_node_put() - new approach to loops.
Date: Mon, 12 Feb 2024 14:03:29 +0200 [thread overview]
Message-ID: <ZcoJEUTdMAKdMHd1@smile.fi.intel.com> (raw)
In-Reply-To: <20240211174237.182947-1-jic23@kernel.org>
On Sun, Feb 11, 2024 at 05:42:28PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Since RFC:
> - Provide a for_each_available_child_of_node_scoped() variant and
> use that whenever we aren't specifically trying to include disabled
> nodes.
> - Fix the for_each_child_of_node_scoped() to not use a mix of
> _available_ and other calls.
> - Include a few more examples. The last one is there to show that
> not all uses of the __free(device_node) call are due to the loops.
I'm a bit skeptical about need of this work. What I would prefer to see
is getting rid of OF-centric drivers in IIO. With that, we would need
only fwnode part to be properly implemented.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-12 12:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 17:42 [PATCH 0/8] of: automate of_node_put() - new approach to loops Jonathan Cameron
2024-02-11 17:42 ` [PATCH 1/8] of: Add cleanup.h based auto release via __free(device_node) markings Jonathan Cameron
2024-02-11 17:42 ` [PATCH 2/8] of: Introduce for_each_*_child_of_node_scoped() to automate of_node_put() handling Jonathan Cameron
2024-02-12 8:20 ` Julia Lawall
2024-02-12 11:37 ` Jonathan Cameron
2024-02-11 17:42 ` [PATCH 3/8] of: unittest: Use for_each_child_of_node_scoped() Jonathan Cameron
2024-02-11 17:42 ` [PATCH 4/8] iio: adc: fsl-imx25-gcq: Use for_each_available_child_node_scoped() Jonathan Cameron
2024-02-11 17:42 ` [PATCH 5/8] iio: adc: rcar-gyroadc: use for_each_available_child_node_scoped() Jonathan Cameron
2024-02-11 17:42 ` [PATCH 6/8] iio: adc: ad7124: Use for_each_available_child_of_node_scoped() Jonathan Cameron
2024-02-11 17:42 ` [PATCH 7/8] iio: adc: ad7292: " Jonathan Cameron
2024-02-11 17:42 ` [PATCH 8/8] iio: adc: adi-axi-adc: Use __free(device_node) and guard(mutex) Jonathan Cameron
2024-02-12 12:03 ` Andy Shevchenko [this message]
2024-02-16 14:47 ` [PATCH 0/8] of: automate of_node_put() - new approach to loops Jonathan Cameron
2024-02-16 15:25 ` Andy Shevchenko
2024-02-23 9:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcoJEUTdMAKdMHd1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Julia.Lawall@inria.fr \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=nuno.sa@analog.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sylphrenadin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox