public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Parri <parri.andrea@gmail.com>
To: Samuel Holland <samuel.holland@sifive.com>
Cc: "Palmer Dabbelt" <palmer@dabbelt.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Jason Baron" <jbaron@akamai.com>,
	"Josh Poimboeuf" <jpoimboe@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	bpf@vger.kernel.org, "Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Björn Töpel" <bjorn@rivosinc.com>
Subject: Re: [PATCH 0/7] riscv: Various text patching improvements
Date: Tue, 13 Feb 2024 13:58:37 +0100	[thread overview]
Message-ID: <ZctnfZWWO3HCiXe5@andrea> (raw)
In-Reply-To: <20240212025529.1971876-1-samuel.holland@sifive.com>

Hi Samuel,

On Sun, Feb 11, 2024 at 06:55:11PM -0800, Samuel Holland wrote:
> Here are a few changes to minimize calls to stop_machine() and
> flush_icache_*() in the various text patching functions, as well as
> to simplify the code.
> 
> 
> Samuel Holland (7):
>   riscv: jump_label: Batch icache maintenance
>   riscv: jump_label: Simplify assembly syntax
>   riscv: kprobes: Use patch_text_nosync() for insn slots
>   riscv: Simplify text patching loops
>   riscv: Pass patch_text() the length in bytes
>   riscv: Use offset_in_page() in text patching functions
>   riscv: Remove extra variable in patch_text_nosync()

This does look like a nice clean-up.  Just curious (a "teach me"-like question),
how did you test these changes? kselftests, micro-benchmarks, other?

BTW, I recall a parallel work from Alex and Bjorn [1] that might have some minor
conflict with these changes; + both of them to Cc: for further sync.

  Andrea

[1] https://lore.kernel.org/lkml/20240206204607.527195-1-alexghiti@rivosinc.com/



  parent reply	other threads:[~2024-02-13 12:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12  2:55 [PATCH 0/7] riscv: Various text patching improvements Samuel Holland
2024-02-12  2:55 ` [PATCH 1/7] riscv: jump_label: Batch icache maintenance Samuel Holland
2024-02-19 12:27   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 2/7] riscv: jump_label: Simplify assembly syntax Samuel Holland
2024-02-19 12:27   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 3/7] riscv: kprobes: Use patch_text_nosync() for insn slots Samuel Holland
2024-02-19 12:52   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 4/7] riscv: Simplify text patching loops Samuel Holland
2024-02-19 13:03   ` Björn Töpel
2024-02-19 22:13     ` David Laight
2024-03-27 15:12       ` Samuel Holland
2024-03-27 15:11     ` Samuel Holland
2024-02-12  2:55 ` [PATCH 5/7] riscv: Pass patch_text() the length in bytes Samuel Holland
2024-02-19 13:04   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 6/7] riscv: Use offset_in_page() in text patching functions Samuel Holland
2024-02-19 13:07   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 7/7] riscv: Remove extra variable in patch_text_nosync() Samuel Holland
2024-02-19 13:08   ` Björn Töpel
2024-02-13 12:58 ` Andrea Parri [this message]
2024-02-19 12:25   ` [PATCH 0/7] riscv: Various text patching improvements Björn Töpel
2024-02-20 22:11     ` Alexandre Ghiti
2024-03-27 15:32   ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZctnfZWWO3HCiXe5@andrea \
    --to=parri.andrea@gmail.com \
    --cc=alexghiti@rivosinc.com \
    --cc=ardb@kernel.org \
    --cc=bjorn@rivosinc.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jbaron@akamai.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=samuel.holland@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox