Re: [PATCH v6 4/6] serial: core: Add support for DEVNAME:0.0 style naming for kernel console

Dan Carpenter
2024-02-14T09:00:19Z

Hi Tony,

kernel test robot noticed the following build warnings:

url: https://github.com/intel-lab-lkp/linux/commits/Tony-Lindgren/printk-Save-console-options-for-add_preferred_console_match/20240213-171012
base: 6cc3028f797a549f256d593867a769ab6a8265f2
patch link: https://lore.kernel.org/r/20240213084545.40617-5-tony%40atomide.com
patch subject: [PATCH v6 4/6] serial: core: Add support for DEVNAME:0.0 style naming for kernel console
config: i386-randconfig-141-20240214 (https://download.01.org/0day-ci/archive/20240214/202402141619.BqEGGzwm-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202402141619.BqEGGzwm-lkp@intel.com/

smatch warnings:
drivers/tty/serial/serial_base_bus.c:255 serial_base_add_preferred_console() error: uninitialized symbol 'port_match'.

vim +/port_match +255 drivers/tty/serial/serial_base_bus.c

a2020a9ccacd63 Tony Lindgren 2024-02-13 252 int serial_base_add_preferred_console(struct uart_driver *drv,
a2020a9ccacd63 Tony Lindgren 2024-02-13 253 struct uart_port *port)
a2020a9ccacd63 Tony Lindgren 2024-02-13 254 {
a2020a9ccacd63 Tony Lindgren 2024-02-13 @255 const char *port_match __free(kfree);

Someone should add this to checkpatch. These always need to be
initialized to NULL.

a2020a9ccacd63 Tony Lindgren 2024-02-13 256 int ret;
a2020a9ccacd63 Tony Lindgren 2024-02-13 257
a2020a9ccacd63 Tony Lindgren 2024-02-13 258 ret = serial_base_add_prefcon(drv->dev_name, port->line);
a2020a9ccacd63 Tony Lindgren 2024-02-13 259 if (ret)
a2020a9ccacd63 Tony Lindgren 2024-02-13 260 return ret;
a2020a9ccacd63 Tony Lindgren 2024-02-13 261
a2020a9ccacd63 Tony Lindgren 2024-02-13 262 port_match = kasprintf(GFP_KERNEL, "%s:%i.%i", dev_name(port->dev),
a2020a9ccacd63 Tony Lindgren 2024-02-13 263 port->ctrl_id, port->port_id);
a2020a9ccacd63 Tony Lindgren 2024-02-13 264 if (!port_match)
a2020a9ccacd63 Tony Lindgren 2024-02-13 265 return -ENOMEM;
a2020a9ccacd63 Tony Lindgren 2024-02-13 266
a2020a9ccacd63 Tony Lindgren 2024-02-13 267 /* Translate a hardware addressing style console=DEVNAME:0.0 */
a2020a9ccacd63 Tony Lindgren 2024-02-13 268 return serial_base_add_one_prefcon(port_match, drv->dev_name, port->line);
a2020a9ccacd63 Tony Lindgren 2024-02-13 269 }

--
0-DAY CI Kernel Test Service