From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C3270020; Wed, 28 Feb 2024 21:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709157209; cv=none; b=Rkt7pVaf54h21GmIgjd+ZgTZpBN/5cQpqAYR75uS4hl1yeX5oBhoyw5hxCBXfxWsrv7kwbLrqFYuyXwR/0AK9F5QWCL2EQgv4NFd1u8d8QKQF844M1XJjkIgZfzd88C1Oq3De3DkhfTSXPtWQjMOZQXzW/rQ3fHINQiCNFrEcHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709157209; c=relaxed/simple; bh=DXAncb5M5L0FxykniOApRquIQ7d0QWI8AZKaQoqhSto=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AYZ7FHq008iEHwvP9VXvNCUPaXAfl7ru91BSpET/lTMVIcPviNCBexuKgTSKiUPETGfB0rwZVZE3oKiNpb38SziLqjMDmbpqGnFO4WYTPkvzJa1FwUj9g7kN2JbAq+JFzw3I7ZTYtoKbC6HCUZdc8p6V4oMVSyZbGqReCI/CQvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FwyEWm8N; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FwyEWm8N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709157207; x=1740693207; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DXAncb5M5L0FxykniOApRquIQ7d0QWI8AZKaQoqhSto=; b=FwyEWm8NnFZq9TCcGO+GXkLBsqwe/ihXTjdDYgmFZnZB3PUlAPaRXo19 6zo2UDl/a2MtYnzaxPJGsZFH6f7sIrFkYEZ335IvHaTVdobP+gSqVhu8i 2OZE6y8DGqMF0Bye80GmncJtewe6LayRAf6TC3ViSTdijb2S+jf/rT8f/ X0ehQBv3HB4qhMKnAMnPuYlEnZ7TiBzrF22c/sx65LdEV+q2NUFaDsy0L C9C3C+Qh3tx4Q2argv/s9KBQwV1wShPeE/p8uQnzd99mFT2rJ5CVKy+NM o76GO69MCxzvO0jDQSI0tJNQpY4Zir7LSmKlVjgUxvLgXOtmVDYPaZwUj A==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="7373409" X-IronPort-AV: E=Sophos;i="6.06,191,1705392000"; d="scan'208";a="7373409" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 13:53:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="913962225" X-IronPort-AV: E=Sophos;i="6.06,191,1705392000"; d="scan'208";a="913962225" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 13:53:21 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rfRrZ-00000008Vpz-48uU; Wed, 28 Feb 2024 23:53:17 +0200 Date: Wed, 28 Feb 2024 23:53:17 +0200 From: Andy Shevchenko To: Kees Cook Cc: Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 7/8] net-device: Use new helpers from overflow.h in netdevice APIs Message-ID: References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-8-andriy.shevchenko@linux.intel.com> <202402281341.AC67EB6E35@keescook> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202402281341.AC67EB6E35@keescook> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Feb 28, 2024 at 01:46:10PM -0800, Kees Cook wrote: > On Wed, Feb 28, 2024 at 10:41:37PM +0200, Andy Shevchenko wrote: ... > > static inline void *netdev_priv(const struct net_device *dev) > > { > > - return (char *)dev + ALIGN(sizeof(struct net_device), NETDEV_ALIGN); > > + return struct_data_pointer(dev, NETDEV_ALIGN); > > } > > I really don't like hiding these trailing allocations from the compiler. > Why can't something like this be done (totally untested): Below is interesting idea, now at least I started understanding your previous comments. -- With Best Regards, Andy Shevchenko