Re: [PATCH 02/13] dt-bindings: i2c: nomadik: add mobileye,eyeq5-i2c bindings and example

Krzysztof Kozlowski
2024-02-16T10:33:05Z

On 16/02/2024 11:18, Théo Lebrun wrote:
>
>>> + mobileye,id:
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + description: Platform-wide controller ID (integer starting from zero).
>>
>> instance indexes are a NAK. You can use i2cN aliases if you must.
>>
>> Why do you need it? To access OLB? If so, add cell args to the OLB
>> phandle instead.
>
> Why we do what we do: I2C controller must write a 2 bit value depending
> on the bus speed. All I2C controllers write into the same register.

Which register? Your devices do not share IO address space.

> Index is used to compute the shift.
>
> mobileye,olb is a phandle to a syscon. I'll be using i2cN aliases I
> guess.
>
> Thanks,
>
> --
> Théo Lebrun, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Best regards,
Krzysztof