Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED

Andy Shevchenko
2024-02-28T00:04:37Z

On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:

...

> + segment-gpios:
> + description:
> + An array of GPIOs one per segment.

This is a vague description. Please explain the order (e.g., LSB =
'a', MSB = 'g'), use of DP (optional?), etc.

> + minItems: 7

maxItems?

...

> + led-7seg {

Probably it should be more human readable. DT people might suggest
something better.

> + compatible = "generic-gpio-7seg";
> + segment-gpios = <&gpio 0 GPIO_ACTIVE_LOW
> + &gpio 1 GPIO_ACTIVE_LOW
> + &gpio 2 GPIO_ACTIVE_LOW
> + &gpio 3 GPIO_ACTIVE_LOW
> + &gpio 4 GPIO_ACTIVE_LOW
> + &gpio 5 GPIO_ACTIVE_LOW
> + &gpio 6 GPIO_ACTIVE_LOW>;

Dunno how to handle DP. Either we always expect it to be here (as
placeholder) or with additional property.

> + };

--
With Best Regards,
Andy Shevchenko