Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED

Rob Herring
2024-02-28T14:04:25Z

On Wed, Feb 28, 2024 at 10:22:42AM +1300, Chris Packham wrote:
> Add bindings for a generic 7 segment LED display using GPIOs.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v2:
> - Use compatible = "generic-gpio-7seg" to keep checkpatch.pl happy
>
> .../auxdisplay/generic-gpio-7seg.yaml | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml
>
> diff --git a/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml b/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml
> new file mode 100644
> index 000000000000..46d53ebdf413
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/auxdisplay/generic,gpio-7seg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO based LED segment display
> +
> +maintainers:
> + - Chris Packham <chris.packham@alliedtelesis.co.nz>
> +
> +properties:
> + compatible:
> + const: generic-gpio-7seg

'generic' doesn't add anything of value. 7seg is kind of vague. So,
gpio-7-segment?

> +
> + segment-gpios:
> + description:
> + An array of GPIOs one per segment.
> + minItems: 7

How does one know which GPIO is which segment?

Rob