From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 421591CA98 for ; Mon, 19 Feb 2024 04:46:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708317979; cv=none; b=f0v5zy5MdkprzGJq5AvEkOy+Hr+uR7p/JBPEnXC6r7/DZjGErWV97JFwH0kt3eV71AgYJkY9BRKaJ9PUSzWGOVVIDuPbKA5xyQS6GaRhU/FGcqeZvRDL/ksdX+E5zRJvGvqZQVFgWhGhb8xDSGtcP0OfAUrHBSO6smnNWahhhGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708317979; c=relaxed/simple; bh=vLqLzH3ZR5ExPctciaBnN6OY0xRtFwrIXQU1oSpMlGo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sexQla5D/8xtzqF5HeSQrebFrW2RX96MWuSvMNJtTZgQsqJBSkL66d4CSbE2jOjtojdnnfCyTF8hiPs6YlnltjuIK7w+ZTiFxutxBm+dJd0gw0Qgw5zq+O0X00tX198Et0w2P1Tg0oN+l5WhtFJzf6/grkwWLurXyVnRfV5ZCus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=c3ZrRrdk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c3ZrRrdk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708317976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dLXISstnHfpiIpRnh79Jrtq+xnWJNyw4ml3k09pwYAA=; b=c3ZrRrdkwqnl1Q0uUhGzyo0L47EA2ctrlWNyCIfqs5yO9C/BeaKqfAr0Qr6ztEQd4hewiW NS3Y6HfVLPMp6pkFcFWRS/dopAM47sgQ8PBpv7ddcz07qk+WM1fwScFn6ANALVWh6OvhOv REOOP4JMUypPhQffrKGL5FeHgJOpo7Y= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-3JnxGZhPN4OftMT9bGeA-A-1; Sun, 18 Feb 2024 23:46:12 -0500 X-MC-Unique: 3JnxGZhPN4OftMT9bGeA-A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E49291C0BB43; Mon, 19 Feb 2024 04:46:10 +0000 (UTC) Received: from localhost (unknown [10.72.116.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36F7BC03282; Mon, 19 Feb 2024 04:46:09 +0000 (UTC) Date: Mon, 19 Feb 2024 12:46:03 +0800 From: Baoquan He To: "Kirill A. Shutemov" Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , Adrian Hunter , Kuppuswamy Sathyanarayanan , Elena Reshetova , Jun Nakajima , Rick Edgecombe , Tom Lendacky , "Kalra, Ashish" , Sean Christopherson , "Huang, Kai" , kexec@lists.infradead.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCHv7 02/16] x86/apic: Mark acpi_mp_wake_* variables as __ro_after_init Message-ID: References: <20240212104448.2589568-1-kirill.shutemov@linux.intel.com> <20240212104448.2589568-3-kirill.shutemov@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212104448.2589568-3-kirill.shutemov@linux.intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 On 02/12/24 at 12:44pm, Kirill A. Shutemov wrote: > acpi_mp_wake_mailbox_paddr and acpi_mp_wake_mailbox initialized once > during ACPI MADT init and never changed. > > Signed-off-by: Kirill A. Shutemov > Acked-by: Kai Huang Reviewed-by: Baoquan He > --- > arch/x86/kernel/acpi/madt_wakeup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/acpi/madt_wakeup.c b/arch/x86/kernel/acpi/madt_wakeup.c > index 7f164d38bd0b..cf79ea6f3007 100644 > --- a/arch/x86/kernel/acpi/madt_wakeup.c > +++ b/arch/x86/kernel/acpi/madt_wakeup.c > @@ -6,10 +6,10 @@ > #include > > /* Physical address of the Multiprocessor Wakeup Structure mailbox */ > -static u64 acpi_mp_wake_mailbox_paddr; > +static u64 acpi_mp_wake_mailbox_paddr __ro_after_init; > > /* Virtual address of the Multiprocessor Wakeup Structure mailbox */ > -static struct acpi_madt_multiproc_wakeup_mailbox *acpi_mp_wake_mailbox; > +static struct acpi_madt_multiproc_wakeup_mailbox *acpi_mp_wake_mailbox __ro_after_init; > > static int acpi_wakeup_cpu(u32 apicid, unsigned long start_ip) > { > -- > 2.43.0 >