From: Matthew Wilcox <willy@infradead.org>
To: lipeifeng@oppo.com
Cc: akpm@linux-foundation.org, david@redhat.com, osalvador@suse.de,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Support kshrinkd
Date: Mon, 19 Feb 2024 16:51:07 +0000 [thread overview]
Message-ID: <ZdOG-135dLP0IeU8@casper.infradead.org> (raw)
In-Reply-To: <20240219141703.3851-1-lipeifeng@oppo.com>
On Mon, Feb 19, 2024 at 10:17:01PM +0800, lipeifeng@oppo.com wrote:
> 'commit 6d4675e60135 ("mm: don't be stuck to rmap lock on reclaim path")'
> The above patch would avoid reclaim path to stuck rmap lock.
> But it would cause some folios in LRU not sorted by aging because
> the contended-folios in rmap_walk would be putbacked to the head of LRU
> during shrink_folio_list even if the folios are very cold.
>
> The patchset setups new kthread:kshrinkd to reclaim the contended-folio
> in rmap_walk when shrink_folio_list, to avoid to break the rules of LRU.
Patch 1/2 didn't make it to my inbox or to lore. But you should talk
about the real world consequences of this in the cover letter. What do
we observe if this problem happens? How much extra performance will we
gain by applying this patch?
next prev parent reply other threads:[~2024-02-19 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 14:17 [PATCH 0/2] Support kshrinkd lipeifeng
2024-02-19 14:17 ` [PATCH 1/2] mm/rmap: support folio_referenced to control if try_lock in rmap_walk lipeifeng
2024-02-20 1:42 ` 李培锋
2024-02-20 3:01 ` Barry Song
2024-02-20 4:00 ` 李培锋
2024-02-20 7:16 ` Barry Song
2024-02-19 14:17 ` [PATCH 2/2] mm: support kshrinkd lipeifeng
2024-02-20 2:11 ` 李培锋
2024-02-20 3:19 ` Barry Song
2024-02-19 16:51 ` Matthew Wilcox [this message]
2024-02-20 2:04 ` [PATCH 0/2] Support kshrinkd 李培锋
2024-02-20 2:55 ` Matthew Wilcox
2024-02-20 4:14 ` 李培锋
2024-02-20 2:09 ` 李培锋
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdOG-135dLP0IeU8@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lipeifeng@oppo.com \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox