From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62BF25478B for ; Mon, 19 Feb 2024 21:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708379591; cv=none; b=SQZ4L2yQ9+cC/Ttl8Lq1FAQxUZNcuREWIdJozwQs0ozZuesQzvu017rhtyTAG6zKfr9Td5ixUuln9VmEYO6oyMReCxow3wgmUCq0HbHD8lIQ1pFDGVRYxBkgwzOltOXSELz/G/ekyCRwaiJmYk/Q74RGGT3mrWv/FEBP8WFHwE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708379591; c=relaxed/simple; bh=KGtvedv9J2Q+aICQY5KyN44vvbdTifr327wYhVDJi8E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UR5EltilSuYiqtMoxLfhR5LgxBbdvKhvP8CsDWKHM9gcBk175jd6M8pFCN/nELluqSUfu/XcMs48A5WzzzvPCjPCT+B1IKi66MR+Quon6Bk4VwagowLC8OI+f+9ThXbXrgUjkfJZAaiEBWqZkvdRUoWTYQDcDGMR/DUuEyVxUj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1JFzGjYH; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1JFzGjYH" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6e41d856114so1630054b3a.1 for ; Mon, 19 Feb 2024 13:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708379589; x=1708984389; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NFqpZSKH861BhiQTTyjzCdqprlBqo4gmUGK5oD0uOYg=; b=1JFzGjYH+qQBGS6AZb6Hccf3ZgWZ8pLNsC4jeBi+b+wvp39bqE9dCKwECDCyq6U1Zk ztPCCBfzc2keaPLNoRhbGK5UOUPdiC0XPQ5dCh7y/CzLFLx7g3c1rMUUuACtX1opfmQ9 2E5ZuSgclRzfM8rq5MvNzGGsmFhwzrZsNDgpmPloSke3rZfyfUozXWoMwptzpruV7xA0 d+uTdDBRb2okReYH+tQztv1/GpEr3RiD4EzM4dMSrVS1VE/31xtqJzm4kbV7j02ujpD9 +NxWzvBRJyF+on9dpnQLzlypl1oWTal1KxD93Es0A8LpIBdQZVgFy14D3Navy+8o6PZo f3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708379589; x=1708984389; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NFqpZSKH861BhiQTTyjzCdqprlBqo4gmUGK5oD0uOYg=; b=FyEPs8NarNP2Q91KM5z7T5KBDcw5twjZ51wglBnFiEmFMLau8oGDzZJSxDXA8EbXhR 2aEt2h6LHepInmMvQKnCqunWk4bIW2esg+1BqLSbSNaoFPL9/V3O+qtg/W/dbMhM3kO1 Ll07Fi49v4HNCuW4W6kiaVB2dQg2mm9/XXQLKSHdmn114ju8tQT8LSbjtsH8/hzpOyts rLdwwMXlESnwnx65LJ47hQY/hnsswWL4XA9f7FHM9SbuMW12CXhJ23ZRd5Px9nFHsqPr fagPddkGQzzMZpOTYH6TSW3AYiVxZ5R6TMiXqT/xZ+rIUWwxPak4evn6yp0/0zZdw2RA eNUQ== X-Forwarded-Encrypted: i=1; AJvYcCXo+9HCuZg3VAHvHPP5TA07ZlNntQxfc7H9EtNPBIiDxdj741+zsASJmiFRUOqMI+zMJcAYuSS+Lh57JdSTOFq9xkhgFWQspVOT107T X-Gm-Message-State: AOJu0Yx6izsaCIHxD+ImQCH+RzLvt0H5qMtuwyZ7dShrfCnelwWMofhW 05OGUIjmqmhQARRbPJz4H/l5gQh1hrCbBaLGeddKGTNp2FFhOijX85BQKyuHsRI5UJc3awDIqll xVw== X-Google-Smtp-Source: AGHT+IH/Or4BZP7MhcpiaZcbu9MeGySoedOfq752Zz8WMWEBM8KeiUUYdKJIqjjXKI7+Ve8OybP/rzc9484= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:8c09:b0:6e4:5a40:a151 with SMTP id ih9-20020a056a008c0900b006e45a40a151mr22695pfb.1.1708379588868; Mon, 19 Feb 2024 13:53:08 -0800 (PST) Date: Mon, 19 Feb 2024 13:53:07 -0800 In-Reply-To: <20240215152916.1158-13-paul@xen.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240215152916.1158-1-paul@xen.org> <20240215152916.1158-13-paul@xen.org> Message-ID: Subject: Re: [PATCH v13 12/21] KVM: x86/xen: allow shared_info to be mapped by fixed HVA From: Sean Christopherson To: Paul Durrant Cc: Paolo Bonzini , Jonathan Corbet , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , David Woodhouse , Shuah Khan , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Thu, Feb 15, 2024, Paul Durrant wrote: > @@ -715,13 +731,23 @@ int kvm_xen_hvm_get_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data) > break; > > case KVM_XEN_ATTR_TYPE_SHARED_INFO: > - if (kvm->arch.xen.shinfo_cache.active) > + if (kvm->arch.xen.shinfo_cache.active && > + kvm->arch.xen.shinfo_cache.gpa != KVM_XEN_INVALID_GPA) This should really use INVALID_GPA when checking internal gpc state. Mostly to help clarify what is/isn't KVM Xen ABI, but also because I don't like the subtle assumption that KVM_XEN_INVALID_GPA == INVALID_GPA. Even better, if we slot in two helpers when the HVA-based GPC support is added, then the Xen code doesn't need to to make assumptions about how the GPC code manages HVA vs. GPA internally. E.g. if we ever refactor the code again and use a dedicated flag instead of gpc->gpa as the implicit flag. static inline bool kvm_gpc_is_gpa_active(struct gfn_to_pfn_cache *gpc) { return gpc->active && !kvm_is_error_gpa(gpc->gpa); } static inline bool kvm_gpc_is_hva_active(struct gfn_to_pfn_cache *gpc) { return gpc->active && kvm_is_error_gpa(gpc->gpa); }