public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	lars@metafoo.de, ang.iglesiasg@gmail.com,
	linus.walleij@linaro.org, semen.protsenko@linaro.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI support
Date: Tue, 20 Feb 2024 15:51:36 +0200	[thread overview]
Message-ID: <ZdSuaLA36yPrdwqz@smile.fi.intel.com> (raw)
In-Reply-To: <20240219195145.GA18787@vamoiridPC>

On Mon, Feb 19, 2024 at 08:51:45PM +0100, Vasileios Amoiridis wrote:
> On Mon, Feb 19, 2024 at 07:42:36PM +0000, Jonathan Cameron wrote:
> > On Mon, 19 Feb 2024 20:13:59 +0100
> > Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> > 
> > > According to the datasheet of BMP38x and BMP390 devices, for an SPI
> > > read operation the first byte that is returned needs to be dropped,
> > > and the rest of the bytes are the actual data returned from the
> > > sensor.
> > > 
> > > Fixes: 8d329309184d ("iio: pressure: bmp280: Add support for BMP380 sensor family")
> > No line break. The fixes tag is part of the main tag block.
> > I can fix that whilst applying.
> > Otherwise this looks fine to me.
> > 
> > I'll leave it on list a little longer though as both Linus and Angel
> > are still about and might have time to also take a look at this.
> >
> 
> Thank you very much again for the quick answer. Since you can fix it while applying,
> I should not annoy the mailing list with more e-mails. Just for future reference,
> when you mean no line break you mean between the main block and the "Fixes" line
> or between the "Fixes" line and the "Signed-off-by: ...." ? 
> > > 
> > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>

The standard pattern for the patch (as it is seen in the `git log`):

---8<---

iio: ...Subject line, summary of the change...
BLANK LINE
...Multi-line description, may contain blank lines...
BLANK LINE
...Tag block: SoB, Rb, etc. tags (may NOT contain blank lines)...

---8<---

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-02-20 13:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 19:13 [PATCH] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI support Vasileios Amoiridis
2024-02-19 19:42 ` Jonathan Cameron
2024-02-19 19:51   ` Vasileios Amoiridis
2024-02-20 13:51     ` Andy Shevchenko [this message]
2024-02-19 23:30 ` Angel Iglesias
2024-02-20 14:09 ` Andy Shevchenko
2024-02-20 17:46   ` Vasileios Amoiridis
2024-02-20 17:54     ` Andy Shevchenko
2024-02-20 17:55     ` Jonathan Cameron
2024-02-24 16:30 ` Jonathan Cameron
2024-03-06 18:08   ` Vasileios Amoiridis
2024-03-09 18:04     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdSuaLA36yPrdwqz@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=ang.iglesiasg@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=vassilisamir@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox