From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, ang.iglesiasg@gmail.com,
linus.walleij@linaro.org, semen.protsenko@linaro.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI support
Date: Tue, 20 Feb 2024 19:54:29 +0200 [thread overview]
Message-ID: <ZdTnVUlsME7gtvrf@smile.fi.intel.com> (raw)
In-Reply-To: <20240220174624.GA27576@vamoiridPC>
On Tue, Feb 20, 2024 at 06:46:24PM +0100, Vasileios Amoiridis wrote:
> On Tue, Feb 20, 2024 at 04:09:26PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 19, 2024 at 08:13:59PM +0100, Vasileios Amoiridis wrote:
...
> > > #include <linux/spi/spi.h>
> > > #include <linux/err.h>
> > > #include <linux/regmap.h>
> > > +#include <linux/bits.h>
> >
> > I see that it's unsorted, but try to squeeze a new header to the better place
> > where more will be kept sorted. With given context, it should go before all
> > others, but it might be even better location.
>
> So you would suggest a re-ordering of the headers with a reverse
> christmas-tree?
No. Alphabetically.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-20 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 19:13 [PATCH] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI support Vasileios Amoiridis
2024-02-19 19:42 ` Jonathan Cameron
2024-02-19 19:51 ` Vasileios Amoiridis
2024-02-20 13:51 ` Andy Shevchenko
2024-02-19 23:30 ` Angel Iglesias
2024-02-20 14:09 ` Andy Shevchenko
2024-02-20 17:46 ` Vasileios Amoiridis
2024-02-20 17:54 ` Andy Shevchenko [this message]
2024-02-20 17:55 ` Jonathan Cameron
2024-02-24 16:30 ` Jonathan Cameron
2024-03-06 18:08 ` Vasileios Amoiridis
2024-03-09 18:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdTnVUlsME7gtvrf@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox