From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6497353816; Wed, 21 Feb 2024 13:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521217; cv=none; b=L9OqUmxKy1l4nWhWKNdJvzXwNReFRGJaYn/DHM5LC67F6PvyccA5bjRWtyD0uJFRCGwfsGp6+5gpcXXsDgnW7jppE7xHt82lrRNDO4sojGvjIO3EtSqtTypkj62FFcZoOyZPN8mHMyEfprsNE8UCwiQfHTchuxvdiV2cW0fpccE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521217; c=relaxed/simple; bh=2GVfeT/gobu3+8GT9oAkEUuXnH2POQPwjFLVQB0cX34=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SbeYzO3tM9zqEWHU/1bsFCE0GOQyeVr0NnFtYFNNIPUSV5QAC5qwFvZ4fKfGVrtN7mV9zOvRAR3X/X0KoEcqGGOzVTnAiOEpKWKsWIwGwyim+PJlz7DXBhh4VUbE8pXrbrxFzJGo6zG4lLs8wOSKA/ZN6+tzc363RC3umgeRey8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="6454518" X-IronPort-AV: E=Sophos;i="6.06,175,1705392000"; d="scan'208";a="6454518" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 05:13:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="913302142" X-IronPort-AV: E=Sophos;i="6.06,175,1705392000"; d="scan'208";a="913302142" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 05:13:26 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rcmPY-00000006M4t-3IcO; Wed, 21 Feb 2024 15:13:20 +0200 Date: Wed, 21 Feb 2024 15:13:20 +0200 From: Andy Shevchenko To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 02/18] pinctrl: pinctrl-single: remove dead code in suspend() and resume() callbacks Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-2-5c2e4a3fac1f@bootlin.com> <78add459-a96a-46c6-83ff-e2657d4d3db4@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Feb 21, 2024 at 12:01:43PM +0100, Thomas Richard wrote: > On 2/16/24 16:08, Andy Shevchenko wrote: > > On Fri, Feb 16, 2024 at 08:59:47AM +0100, Thomas Richard wrote: > >> On 2/15/24 16:27, Andy Shevchenko wrote: > >>> On Thu, Feb 15, 2024 at 04:17:47PM +0100, Thomas Richard wrote: > >>>> No need to check the pointer returned by platform_get_drvdata(), as > >>>> platform_set_drvdata() is called during the probe. > >>> > >>> This patch should go _after_ the next one, otherwise the commit message doesn't > >>> tell full story and the code change bring a potential regression. > >> > >> Hello Andy, > >> > >> I'm ok to move this patch after the next one. > >> But for my understanding, could you explain me why changing the order is > >> important in this case ? > > > > Old PM calls obviously can be called in different circumstances and these > > checks are important. > > > > Just squash these two patches to avoid additional churn and we are done. > > You mean invert the order instead of squash. Either would work, but see how much churn in terms of changing just changed lines it adds. -- With Best Regards, Andy Shevchenko