Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type

Andy Shevchenko
2024-02-21T18:53:24Z

On Wed, Feb 21, 2024 at 10:47:13AM -0800, Florian Fainelli wrote:
> On 2/21/24 10:31, Andy Shevchenko wrote:

...

> > unsigned char iotype; /* io access style */
> > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */
>
> Nit: I would name this UPIO_UNKNOWN, or UPIO_NOTSET, unset means to me that
> it was previously set and we undid that action, whereas unknown or not set
> means we never did.

Works for me. I will wait for a few days / week to have more reviews and
likely testings to be collected. Would be nice if you be able to test on
(some of) the hardware in the list of modified drivers.

--
With Best Regards,
Andy Shevchenko