Re: [PATCH 1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP bus support

Andrey Skvortsov
2024-02-22T05:52:38Z

On 24-02-20 10:46, Sakari Ailus wrote:
> Hi Andrey,
>
> Thanks for the patchset.
>
> On Sun, Feb 18, 2024 at 01:03:07AM +0300, Andrey Skvortsov wrote:
> > Don't require link-frequencies like it's done for ov5640, that
> > supports both CSI-2 and DVP. And v4l2_fwnode_endpoint_alloc_parse
> > ignores link-frequencies property for DVP endpoint. It's used only for
> > CSI-2 endpoints
> >
> > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> > ---
> > .../bindings/media/i2c/galaxycore,gc2145.yaml | 33 +++++++++++++++++--
> > 1 file changed, 30 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > index 1726ecca4c77..fb376b9d0f2a 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > @@ -61,9 +61,6 @@ properties:
> > properties:
> > link-frequencies: true
> >
> > - required:
> > - - link-frequencies
>
> That seems like a bad idea to me.
>
> While for parallel interface it may not be often important, for CSI-2 it
> should stay.

I'll add this type and make link-frequencies required based on that
for CSI-2 bus.

>
> > -
> > required:
> > - endpoint
> >
> > @@ -110,4 +107,34 @@ examples:
> > };
> > };
> >
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + camera@3c {
> > + compatible = "galaxycore,gc2145";
> > + reg = <0x3c>;
> > + clocks = <&clk_ext_camera>;
> > + iovdd-supply = <&scmi_v3v3_sw>;
> > + avdd-supply = <&scmi_v3v3_sw>;
> > + dvdd-supply = <&scmi_v3v3_sw>;
> > + powerdown-gpios = <&mcp23017 3 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
> > + reset-gpios = <&mcp23017 4 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
> > +
> > + port {
> > + endpoint {
> > + remote-endpoint = <&parallel_from_gc2145>;
> > + bus-width = <8>;
> > + hsync-active = <1>;
> > + vsync-active = <1>;
> > + data-active = <1>;
> > + pclk-sample = <1>;
>
> Are there defaults for these if there are no such properties?

good point. I'll add them to the endpoint properties description then.

--
Best regards,
Andrey Skvortsov