Re: [PATCH 1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP bus support

Sakari Ailus
2024-02-20T10:48:03Z

On Tue, Feb 20, 2024 at 10:46:23AM +0000, Sakari Ailus wrote:
> Hi Andrey,
>
> Thanks for the patchset.
>
> On Sun, Feb 18, 2024 at 01:03:07AM +0300, Andrey Skvortsov wrote:
> > Don't require link-frequencies like it's done for ov5640, that
> > supports both CSI-2 and DVP. And v4l2_fwnode_endpoint_alloc_parse
> > ignores link-frequencies property for DVP endpoint. It's used only for
> > CSI-2 endpoints
> >
> > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> > ---
> > .../bindings/media/i2c/galaxycore,gc2145.yaml | 33 +++++++++++++++++--
> > 1 file changed, 30 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > index 1726ecca4c77..fb376b9d0f2a 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > @@ -61,9 +61,6 @@ properties:
> > properties:
> > link-frequencies: true
> >
> > - required:
> > - - link-frequencies
>
> That seems like a bad idea to me.
>
> While for parallel interface it may not be often important, for CSI-2 it
> should stay.

You're also missing the bus-type property which should default to CSI-2
D-PHY.

--
Sakari Ailus