From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
allen.lkml@gmail.com, kernel-team@meta.com
Subject: Re: [PATCH 6/7] workqueue: Allow cancel_work_sync() and disable_work() from atomic contexts on BH work items
Date: Wed, 21 Feb 2024 22:32:17 -1000 [thread overview]
Message-ID: <ZdcGkd3u190NzCw8@slm.duckdns.org> (raw)
In-Reply-To: <CAJhGHyAOzXVwGy5T-KXpwXgcWp6jLaTGGzspPqQU4Dw+x1GqUg@mail.gmail.com>
Hello,
On Thu, Feb 22, 2024 at 12:36:29PM +0800, Lai Jiangshan wrote:
> On Thu, Feb 22, 2024 at 1:43 AM Tejun Heo <tj@kernel.org> wrote:
>
> > @@ -4077,11 +4076,37 @@ static bool __flush_work(struct work_struct *work, bool from_cancel)
> >
> > rcu_read_lock();
> > pool = start_flush_work(work, &barr, from_cancel);
> > + is_bh = pool && (pool->flags & POOL_BH);
> > rcu_read_unlock();
> > if (!pool)
> > return false;
> >
> > - wait_for_completion(&barr.done);
> > + if (is_bh && from_cancel) {
>
> Can "*work_data_bits(work) & WORK_OFFQ_BH" be used here?
> If so, the previous patch will not be needed.
Hmm... yeah, if we test from_cancel first, we should know that the work item
is offq and then can depend on OFFQ_BH. Maybe I'm missing something. Will
try that.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-02-22 8:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 17:42 [PATCHSET v2 wq/6.10] workqueue: Implement disable/enable_work() Tejun Heo
2024-02-21 17:42 ` [PATCH 1/7] workqueue: Preserve OFFQ bits in cancel[_sync] paths Tejun Heo
2024-02-22 4:35 ` Lai Jiangshan
2024-02-22 8:05 ` Tejun Heo
2024-02-21 17:43 ` [PATCH 2/7] workqueue: Implement disable/enable for (delayed) work items Tejun Heo
2024-02-22 4:34 ` Lai Jiangshan
2024-02-22 8:22 ` Tejun Heo
2024-02-21 17:43 ` [PATCH 3/7] workqueue: Remove WORK_OFFQ_CANCELING Tejun Heo
2024-02-21 17:43 ` [PATCH 4/7] workqueue: Remember whether a work item was on a BH workqueue Tejun Heo
2024-02-21 17:43 ` [PATCH 5/7] workqueue: Update how start_flush_work() is called Tejun Heo
2024-02-21 17:43 ` [PATCH 6/7] workqueue: Allow cancel_work_sync() and disable_work() from atomic contexts on BH work items Tejun Heo
2024-02-22 4:36 ` Lai Jiangshan
2024-02-22 8:32 ` Tejun Heo [this message]
2024-02-21 17:43 ` [PATCH 7/7] r8152: Convert from tasklet to BH workqueue Tejun Heo
2024-02-22 3:33 ` [PATCHSET v2 wq/6.10] workqueue: Implement disable/enable_work() Lai Jiangshan
2024-02-22 4:59 ` Lai Jiangshan
2024-02-22 8:56 ` Tejun Heo
2024-02-22 9:16 ` Tejun Heo
2024-02-25 10:55 ` Lai Jiangshan
2024-02-26 18:53 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdcGkd3u190NzCw8@slm.duckdns.org \
--to=tj@kernel.org \
--cc=allen.lkml@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox