Re: [PATCH v1 01/14] serial: core: Move struct uart_port::quirks closer to possible values

Hugo Villeneuve
2024-02-21T18:55:10Z

On Wed, 21 Feb 2024 20:31:17 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Currently it's not crystal clear what UPIO_* and UPQ_* definitions
> belong two. Reindent the code, so it will be easy to read and understand.

two -> to.

Hugo V.

> No functional changes intended.
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/serial_core.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index 55b1f3ba48ac..2d2ec99eca93 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -467,8 +467,8 @@ struct uart_port {
> unsigned int fifosize; /* tx fifo size */
> unsigned char x_char; /* xon/xoff char */
> unsigned char regshift; /* reg offset shift */
> +
> unsigned char iotype; /* io access style */
> - unsigned char quirks; /* internal quirks */
>
> #define UPIO_PORT (SERIAL_IO_PORT) /* 8b I/O port access */
> #define UPIO_HUB6 (SERIAL_IO_HUB6) /* Hub6 ISA card */
> @@ -479,7 +479,9 @@ struct uart_port {
> #define UPIO_MEM32BE (SERIAL_IO_MEM32BE) /* 32b big endian */
> #define UPIO_MEM16 (SERIAL_IO_MEM16) /* 16b little endian */
>
> - /* quirks must be updated while holding port mutex */
> + unsigned char quirks; /* internal quirks */
> +
> + /* internal quirks must be updated while holding port mutex */
> #define UPQ_NO_TXEN_TEST BIT(0)
>
> unsigned int read_status_mask; /* driver specific */
> --
> 2.43.0.rc1.1.gbec44491f096
>
>

--
Hugo Villeneuve