Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type

Andy Shevchenko
2024-02-26T14:17:13Z

On Fri, Feb 23, 2024 at 04:59:25PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 23, 2024 at 06:42:15AM +0100, Jiri Slaby wrote:
> > On 22. 02. 24, 14:21, Andy Shevchenko wrote:
> > > On Thu, Feb 22, 2024 at 07:58:32AM +0100, Jiri Slaby wrote:
> > > > On 21. 02. 24, 19:31, Andy Shevchenko wrote:

...

> > > > > unsigned char iotype; /* io access style */
> > > > > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */
> > > >
> > > > Perhaps making the var u8 and this U8_MAX then? It would make more sense to
> > > > me.
> > >
> > > WFM, should it be a separate change?
> >
> > Likely.
>
> Then I need a commit message, because I'm unable to justify this change myself.
>
> > > Btw, how can I justify it?
> >
> > Hmm, thinking about it, why is it not an enum?
>
> Maybe, but it is a replica of UAPI definitions, do we want to see it as a enum?
> To me it will be a bit ugly looking.
>
> > But it could be also an u8 because you want it be exactly 8 bits as you want
> > to be sure values up to 255 fit.
>
> Depends on what we assume UAPI does with those flags. It maybe even less than
> 8 bits, or great than, currently 8 bits is enough...
>
> TL;DR: I would rather take a patch from you and incorporate into the series
> than trying hard to invent a justification and proper type.

Okay, I want to send a new version, for now I leave the type change for
the next time. It looks that quirks as well will benefit from type clarifying.

--
With Best Regards,
Andy Shevchenko