From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: Use serial8250_do_set_termios for uartclk updating
Date: Thu, 22 Feb 2024 17:05:53 +0200 [thread overview]
Message-ID: <Zddi0S0Esw-dUVIV@smile.fi.intel.com> (raw)
In-Reply-To: <20240222145058.28307-1-fancer.lancer@gmail.com>
On Thu, Feb 22, 2024 at 05:50:56PM +0300, Serge Semin wrote:
> The serial8250_update_uartclk() body was created based on the several
> method calls copied from the serial8250_do_set_termios() function. Seeing
> aside with some other things the later method can update the baud rate
> based on the new reference clock let's just call it instead thus
> simplifying the code a bit.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Link: https://lore.kernel.org/linux-serial/ZczD7KPbeRnY4CFc@black.fi.intel.com
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Thank you! This looks like a good simplification and turning to "one source" of
the same flow principle.
Assuming that it's working on your hardware,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-02-22 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 14:50 [PATCH] serial: 8250: Use serial8250_do_set_termios for uartclk updating Serge Semin
2024-02-22 15:05 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zddi0S0Esw-dUVIV@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox