From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 608AD823A1 for ; Fri, 23 Feb 2024 14:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708698036; cv=none; b=VFhho9DqLXo8QhuldV60KZXPPjBEgRiM3/LNK1cxc6lVjv4GECyOcw/P/6s4dqHAG2W+w82TS1OAMZLjDECAM8CwNSbDv9B+kTYtqxDYK2ZCq/1vcnySWH3z9s1qPXZt6WfWp7PmO96m/1lR1RdL54gHth9wSHOMNke5UELOEXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708698036; c=relaxed/simple; bh=TV2TbTF5HNR+UtY5N1ayGaJ+DSc7ezRUbJP15SLdHEs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Bt7BXhVNc3p/k6P+MPlF+WGz2Vxy0G+MKgB2T/0BokIHiczQDlzjh1SzzknMeTvYo50Ebyl66LGpTSHlgV+hRwBhi1F+Sf2Ikp9bNaMgMnvQTSGoe0feWipdwjn693U43b1irnqJZahQ61Lf36iYz3FUkE1WTRkKcnu7Y0iHSv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OB3PH38m; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OB3PH38m" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-607cd6c11d7so14918317b3.0 for ; Fri, 23 Feb 2024 06:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708698034; x=1709302834; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vZuuePe5dJSpQ6kc+Papl7SiBSTZFtVsqxBtzBME+JE=; b=OB3PH38ms84+EJDNBwr36sET2bW4ceLtNv9nCdqb2omIt12D/4M2vxSQUpi6Fboxfu Fafz0Jgyg9syPxARJyz/IoaAxtU+dxFPf9R/Wgd3d4EwksPRd+KmY4w7BvWoo4+YST28 D4qNK5TMTUKXGCdnd4MShH3QYtooc4dE2PM9rsztuPgN/oFU99eDdE+kMnVipW0bsZk8 d+uDkZC/AjdnLADO/Nk6m55Bu9LuhyjeAcXPDWD9K8p2haVOjof67W5PrEJXJiVLlnEJ 58US+g4X56tgPFIoY2r5LhCoOampJGEvjObRdmYeH0gWupLYnMF1MCEJIfiXlNRYEk// lmlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708698034; x=1709302834; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vZuuePe5dJSpQ6kc+Papl7SiBSTZFtVsqxBtzBME+JE=; b=j447cVQ8zq+N+7HMZfn+rkVNSpy8cCvVVzCe9Pr1sFtmEaHhsmOFYKtXBJs5nZJuKs L5ItYUc54YAhlTy3CpvbZeTOg89guKRGm1ZSMZVQTbb2LH5rSCI8NtkbzN1qTqTEKvmN uUIxoqYRj6DjBRj6fVVD0DUAELZYbefNKe8xTpFWpuIrJ5wdpEKw/2L3hO7QhGhGn91/ mis/eRixcdK1Dv50pujEpnYO48ufxVoAn6BBz8x2lKCuT8FrSI8GKKlJSHzE4bXVy1hw iQ4wg3IEac6jWsrWdQ8YK5k8cKRkTcXKQk23HdgpiwX6TWGwMCOdZ8mWIW3Wa0DSVBcG cvmA== X-Gm-Message-State: AOJu0Yz2JvuzQLZh9MOp+C4gj7yLbpnpdxP/RVbbmMt5lHVzDauMgwrt Xm0zcNwmoy2q+d+A+evnbpj74dZRVf9W0BvVhfVrGW4OVFwa8iDNPJDMEGhg+czki6cjlyC9698 rWw== X-Google-Smtp-Source: AGHT+IEHTg6TFxiespYtA70wAjrucDCk6kM0ronxHGBqeoKErrvrpFr13f6qgnM/+6fcnCWep9y0WRDva5E= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d7d4:0:b0:608:788f:8cfa with SMTP id z203-20020a0dd7d4000000b00608788f8cfamr361155ywd.1.1708698034257; Fri, 23 Feb 2024 06:20:34 -0800 (PST) Date: Fri, 23 Feb 2024 06:20:32 -0800 In-Reply-To: <20240223104009.632194-2-pbonzini@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240223104009.632194-1-pbonzini@redhat.com> <20240223104009.632194-2-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH v2 01/11] KVM: SEV: fix compat ABI for KVM_MEMORY_ENCRYPT_OP From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, michael.roth@amd.com, aik@amd.com Content-Type: text/plain; charset="us-ascii" On Fri, Feb 23, 2024, Paolo Bonzini wrote: > The data structs for KVM_MEMORY_ENCRYPT_OP have different sizes for 32- and 64-bit > kernels, but they do not make any attempt to convert from one ABI to the other. > Fix this by adding the appropriate padding. Maybe call out that SEV+ is 64-bit only, so this doesn't matter in practice? Or does this affect .compat_ioctl()? > No functional change intended for 64-bit userspace. > > Signed-off-by: Paolo Bonzini > Message-Id: <20240209183743.22030-2-pbonzini@redhat.com> > Reviewed-by: Michael Roth > Signed-off-by: Paolo Bonzini Heh, you've double-stamped several of the patches in this series. Reviewed-by: Sean Christopherson