From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A3085D73D; Fri, 23 Feb 2024 14:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708698494; cv=none; b=GBw1Uz2HUkjQ0AFrG5m1oUtVmHzaEhf9hIlIJ+pGE/W+5CoFdIeTeOjZLDsJAVVR+wDpJ8L8YIOzavxQYT43FP/OfJX6IcaJ5+GQ3Kpg/u66wxzWv+euTNXZ4NpXEPho1dEciK1fq1NNGpitcjWCo1GiHXk4mL7oyFwEodPEmMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708698494; c=relaxed/simple; bh=1bwXd+3rlYqKr6S6RrkPkb1QhvUSeD3Xj0QpioEvp0g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mSrVz1UUA3lsaquLoFStDE6ks72c9gih/zEg26KSxtKVDJT1PZnLigSxtIe+aGqYD9HOqHSJfrPjTQSTF+R/ZGLOCAjYx2B/8SlqSyCcr1vL8G44BrSzbxls9aZqCVBChQshvW0oe1zoRZCud9hjskBy5/cod1mpPLOYh5pphQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qlxz5wU2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qlxz5wU2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8D79C433C7; Fri, 23 Feb 2024 14:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708698493; bh=1bwXd+3rlYqKr6S6RrkPkb1QhvUSeD3Xj0QpioEvp0g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qlxz5wU2ZZTXuwZG085sWfqP0F0ZnnIzu6kH36RXg2c3DhQcDJz0r1vaSMXDi6pHv FpJQo8I04ZwU+Z/Aw3NTR5GecprmB+3GUuv56Q3x7H3OZsyIQbgHAvTk3waIZw35ie sE2qErqjfc7sqTKAcmUQKdIkEhUuXYCDGRIIrdudl8Mg0ekVlKrmIfF35bHxKpw1II JKiQE90ysGmye3bdhRVEvdYe5PWnJrfjs39aUE982s5p23bZTn0t/oE8fdPg3BhFog S9PXQKo/F10Ty92RN3E4CqTP6PjUJ6ejXMNcJ3dpx+VPdExSoePrXbaJzYlIT1kBJN G9M+5U/KqYuIg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdWXB-000000004vJ-1N7T; Fri, 23 Feb 2024 15:28:18 +0100 Date: Fri, 23 Feb 2024 15:28:17 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: neil.armstrong@linaro.org, Bjorn Andersson , Andrzej Hajda , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Vinod Koul , Johan Hovold , Jonas Karlman , Laurent Pinchart , Jernej Skrabec , Konrad Dybcio , Kishon Vijay Abraham I , Rob Clark , Abhinav Kumar , Kuogee Hsieh , freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Message-ID: References: <20240217150228.5788-1-johan+linaro@kernel.org> <170868613914.4029284.5549880672870201262.b4-ty@linaro.org> <3c4246b6-431a-442e-8ace-3b0d0e67743f@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 23, 2024 at 04:18:08PM +0200, Dmitry Baryshkov wrote: > On Fri, 23 Feb 2024 at 15:52, Neil Armstrong wrote: > > On 23/02/2024 13:51, Johan Hovold wrote: > > > On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: > > >> On 23/02/2024 12:02, Neil Armstrong wrote: > > >>> Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) > > >>> > > >>> [1/6] drm/bridge: aux-hpd: fix OF node leaks > > >>> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9ee485bdda68d6d3f5728cbe3150eb9013d7d22b > > >>> [2/6] drm/bridge: aux-hpd: separate allocation and registration > > >>> (no commit info) > > >>> [3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free > > >>> (no commit info) > > >>> [4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m > > >>> (no commit info) > > >>> [5/6] phy: qcom-qmp-combo: fix drm bridge registration > > >>> (no commit info) > > >>> [6/6] phy: qcom-qmp-combo: fix type-c switch registration > > >>> (no commit info) > > >>> > > >> > > >> To clarify, I only applied patch 1 to drm-misc-fixes > > > > > > Ok, but can you please not do that? :) > > > > > > These patches should go in through the same tree to avoid conflicts. > > > > > > I discussed this with Bjorn and Dmitry the other day and the conclusion > > > was that it was easiest to take all of these through DRM. > > > > I only applied patch 1, which is a standalone fix and goes into a separate tree, > > for the next patches it would be indeed simpler for them to go via drm-misc when > > they are properly acked. > > I think PHY patches can go through a usual route (phy/next or > phy/fixes). They can, but I've explicitly asked Vinod to ack them so that they can go in with the rest of the series through DRM. They also fix a regression that came in through DRM in 6.8-rc1 (the bridge rework which started registering child devices) so it makes sense to also route the fix the same way. And to do it for this cycle. > For patches 3 and 4 I'd need an ack from Bjorn to merge > them through drm-misc-next or drm-misc-fixes. You have Bjorn's ack. He's reviewed all the patches for this purpose and we discussed this in person two days ago. And, again, this has to go in for *this* cycle. You broke the display on the X13s and other machines so this cannot wait for 6.9. Johan