* [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from devm_extcon_dev_allocate()
@ 2023-12-22 16:18 Andy Shevchenko
2024-02-08 19:24 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2023-12-22 16:18 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel; +Cc: MyungJoo Ham, Chanwoo Choi
Don't shadow error from devm_extcon_dev_allocate() and return it as is.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/extcon/extcon-intel-mrfld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-intel-mrfld.c b/drivers/extcon/extcon-intel-mrfld.c
index 59cc3391bac7..2ee738f844ab 100644
--- a/drivers/extcon/extcon-intel-mrfld.c
+++ b/drivers/extcon/extcon-intel-mrfld.c
@@ -247,7 +247,7 @@ static int mrfld_extcon_probe(struct platform_device *pdev)
data->edev = devm_extcon_dev_allocate(dev, mrfld_extcon_cable);
if (IS_ERR(data->edev))
- return -ENOMEM;
+ return PTR_ERR(data->edev);
ret = devm_extcon_dev_register(dev, data->edev);
if (ret < 0) {
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from devm_extcon_dev_allocate()
2023-12-22 16:18 [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from devm_extcon_dev_allocate() Andy Shevchenko
@ 2024-02-08 19:24 ` Andy Shevchenko
2024-02-22 13:17 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2024-02-08 19:24 UTC (permalink / raw)
To: linux-kernel; +Cc: MyungJoo Ham, Chanwoo Choi
On Fri, Dec 22, 2023 at 06:18:54PM +0200, Andy Shevchenko wrote:
> Don't shadow error from devm_extcon_dev_allocate() and return it as is.
Any comment on this?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from devm_extcon_dev_allocate()
2024-02-08 19:24 ` Andy Shevchenko
@ 2024-02-22 13:17 ` Andy Shevchenko
2024-02-23 7:43 ` Chanwoo Choi
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2024-02-22 13:17 UTC (permalink / raw)
To: linux-kernel; +Cc: MyungJoo Ham, Chanwoo Choi
On Thu, Feb 08, 2024 at 09:24:58PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 22, 2023 at 06:18:54PM +0200, Andy Shevchenko wrote:
> > Don't shadow error from devm_extcon_dev_allocate() and return it as is.
>
> Any comment on this?
Here is another one, can it be applied as well?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from devm_extcon_dev_allocate()
2024-02-22 13:17 ` Andy Shevchenko
@ 2024-02-23 7:43 ` Chanwoo Choi
2024-02-23 14:32 ` 'Andy Shevchenko'
0 siblings, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2024-02-23 7:43 UTC (permalink / raw)
To: 'Andy Shevchenko', linux-kernel; +Cc: 'MyungJoo Ham'
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, February 22, 2024 10:18 PM
> To: linux-kernel@vger.kernel.org
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
> <cw00.choi@samsung.com>
> Subject: Re: [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from
> devm_extcon_dev_allocate()
>
> On Thu, Feb 08, 2024 at 09:24:58PM +0200, Andy Shevchenko wrote:
> > On Fri, Dec 22, 2023 at 06:18:54PM +0200, Andy Shevchenko wrote:
> > > Don't shadow error from devm_extcon_dev_allocate() and return it as
is.
> >
> > Any comment on this?
>
> Here is another one, can it be applied as well?
Applied it. Thanks.
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from devm_extcon_dev_allocate()
2024-02-23 7:43 ` Chanwoo Choi
@ 2024-02-23 14:32 ` 'Andy Shevchenko'
0 siblings, 0 replies; 5+ messages in thread
From: 'Andy Shevchenko' @ 2024-02-23 14:32 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: linux-kernel, 'MyungJoo Ham'
On Fri, Feb 23, 2024 at 04:43:15PM +0900, Chanwoo Choi wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Thursday, February 22, 2024 10:18 PM
> > On Thu, Feb 08, 2024 at 09:24:58PM +0200, Andy Shevchenko wrote:
...
> > Here is another one, can it be applied as well?
>
> Applied it. Thanks.
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-23 14:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-22 16:18 [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from devm_extcon_dev_allocate() Andy Shevchenko
2024-02-08 19:24 ` Andy Shevchenko
2024-02-22 13:17 ` Andy Shevchenko
2024-02-23 7:43 ` Chanwoo Choi
2024-02-23 14:32 ` 'Andy Shevchenko'
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox