Re: [PATCH v4 16/16] ARM: dts: imx6ull-uti260b: Add board

Fabio Estevam
2024-02-25T01:11:15Z

On Sat, Feb 24, 2024 at 6:33 PM Sebastian Reichel <sre@kernel.org> wrote:

> +&gpio2 {
> + /* configuring this to output-high results in poweroff */
> + power-en-hog {
> + gpio-hog;
> + gpios = <6 GPIO_ACTIVE_HIGH>;
> + line-name = "power-en-gpio";
> + output-low;
> + pinctrl-names = "default";
> + pinctrl-0 = <&mux_poweroff2>;
> + };
> +};
> +
> +&ecspi3 {

It is recommended to put the nodes in alphabetical order (except
iomuxc, which is the last one).

> + mux_gc0308: gc0308grp {
> + fsl,pins = <
> + MX6UL_PAD_CSI_MCLK__CSI_MCLK 0x1e038
> + MX6UL_PAD_GPIO1_IO05__GPIO1_IO05 0x1b088
> + MX6UL_PAD_GPIO1_IO06__GPIO1_IO06 0x1b088
> + >;
> + };
> +
> +

There is an extra blank line here.

Reviewed-by: Fabio Estevam <festevam@gmail.com>