[PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

[PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

[Ondřej Jirman]

From: Ondrej Jirman <megi@xff.cz>

The reverted commit makes the state machine only ever go from SRC_ATTACH_WAIT
to SNK_TRY in endless loop when toggling. After revert it goes to SRC_ATTACHED
after initially trying SNK_TRY earlier, as it should for toggling to ever detect
the power source mode and the port is again able to provide power to attached
power sinks.

This reverts commit 2d6d80127006ae3da26b1f21a65eccf957f2d1e5.
---
 drivers/usb/typec/tcpm/tcpm.c | 3 ---
 1 file changed, 3 deletions(-)

See https://lore.kernel.org/all/odggrbbgjpardze76qiv57mw6tllisyu5sbrta37iadjzwamcv@qr3ubwnlzqqt/
for more.

diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index f7d7daa60c8d..295ae7eb912c 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -3743,9 +3743,6 @@ static void tcpm_detach(struct tcpm_port *port)
 	if (tcpm_port_is_disconnected(port))
 		port->hard_reset_count = 0;
 
-	port->try_src_count = 0;
-	port->try_snk_count = 0;
-
 	if (!port->attached)
 		return;
 
-- 
2.43.0

Re: [PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

[Greg Kroah-Hartman]

On Thu, Feb 15, 2024 at 08:33:50PM +0100, Ondřej Jirman wrote:
> From: Ondrej Jirman <megi@xff.cz>
> 
> The reverted commit makes the state machine only ever go from SRC_ATTACH_WAIT
> to SNK_TRY in endless loop when toggling. After revert it goes to SRC_ATTACHED
> after initially trying SNK_TRY earlier, as it should for toggling to ever detect
> the power source mode and the port is again able to provide power to attached
> power sinks.
> 
> This reverts commit 2d6d80127006ae3da26b1f21a65eccf957f2d1e5.
> ---
>  drivers/usb/typec/tcpm/tcpm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> See https://lore.kernel.org/all/odggrbbgjpardze76qiv57mw6tllisyu5sbrta37iadjzwamcv@qr3ubwnlzqqt/
> for more.
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index f7d7daa60c8d..295ae7eb912c 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -3743,9 +3743,6 @@ static void tcpm_detach(struct tcpm_port *port)
>  	if (tcpm_port_is_disconnected(port))
>  		port->hard_reset_count = 0;
>  
> -	port->try_src_count = 0;
> -	port->try_snk_count = 0;
> -
>  	if (!port->attached)
>  		return;
>  
> -- 
> 2.43.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/process/submitting-patches.rst and resend
  it after adding that line.  Note, the line needs to be in the body of
  the email, before the patch, not at the bottom of the patch or in the
  email signature.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

[Ondřej Jirman]

On Sat, Feb 17, 2024 at 04:32:54PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 15, 2024 at 08:33:50PM +0100, Ondřej Jirman wrote:
> > From: Ondrej Jirman <megi@xff.cz>
> > 
> > The reverted commit makes the state machine only ever go from SRC_ATTACH_WAIT
> > to SNK_TRY in endless loop when toggling. After revert it goes to SRC_ATTACHED
> > after initially trying SNK_TRY earlier, as it should for toggling to ever detect
> > the power source mode and the port is again able to provide power to attached
> > power sinks.
> > 
> > This reverts commit 2d6d80127006ae3da26b1f21a65eccf957f2d1e5.
> > ---
> >  drivers/usb/typec/tcpm/tcpm.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > See https://lore.kernel.org/all/odggrbbgjpardze76qiv57mw6tllisyu5sbrta37iadjzwamcv@qr3ubwnlzqqt/
> > for more.
> > 
> > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> > index f7d7daa60c8d..295ae7eb912c 100644
> > --- a/drivers/usb/typec/tcpm/tcpm.c
> > +++ b/drivers/usb/typec/tcpm/tcpm.c
> > @@ -3743,9 +3743,6 @@ static void tcpm_detach(struct tcpm_port *port)
> >  	if (tcpm_port_is_disconnected(port))
> >  		port->hard_reset_count = 0;
> >  
> > -	port->try_src_count = 0;
> > -	port->try_snk_count = 0;
> > -
> >  	if (!port->attached)
> >  		return;
> >  
> > -- 
> > 2.43.0
> > 
> > 
> 
> Hi,
> 
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
> 
> You are receiving this message because of the following common error(s)
> as indicated below:
> 
> - Your patch does not have a Signed-off-by: line.  Please read the
>   kernel file, Documentation/process/submitting-patches.rst and resend
>   it after adding that line.  Note, the line needs to be in the body of
>   the email, before the patch, not at the bottom of the patch or in the
>   email signature.
> 
> 
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.

It's a mechanically generated revert of upstream patch. It has no authorship.
I did not write it, machine did. :)

But I can add a sign off for the commit message I made:

Signed-of-by: Ondrej Jirman <megi@xff.cz>

kind regards,
	o.

> thanks,
> 
> greg k-h's patch email bot

Re: [PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

[Greg Kroah-Hartman]

On Sat, Feb 17, 2024 at 04:40:21PM +0100, Ondřej Jirman wrote:
> On Sat, Feb 17, 2024 at 04:32:54PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Feb 15, 2024 at 08:33:50PM +0100, Ondřej Jirman wrote:
> > > From: Ondrej Jirman <megi@xff.cz>
> > > 
> > > The reverted commit makes the state machine only ever go from SRC_ATTACH_WAIT
> > > to SNK_TRY in endless loop when toggling. After revert it goes to SRC_ATTACHED
> > > after initially trying SNK_TRY earlier, as it should for toggling to ever detect
> > > the power source mode and the port is again able to provide power to attached
> > > power sinks.
> > > 
> > > This reverts commit 2d6d80127006ae3da26b1f21a65eccf957f2d1e5.
> > > ---
> > >  drivers/usb/typec/tcpm/tcpm.c | 3 ---
> > >  1 file changed, 3 deletions(-)
> > > 
> > > See https://lore.kernel.org/all/odggrbbgjpardze76qiv57mw6tllisyu5sbrta37iadjzwamcv@qr3ubwnlzqqt/
> > > for more.
> > > 
> > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> > > index f7d7daa60c8d..295ae7eb912c 100644
> > > --- a/drivers/usb/typec/tcpm/tcpm.c
> > > +++ b/drivers/usb/typec/tcpm/tcpm.c
> > > @@ -3743,9 +3743,6 @@ static void tcpm_detach(struct tcpm_port *port)
> > >  	if (tcpm_port_is_disconnected(port))
> > >  		port->hard_reset_count = 0;
> > >  
> > > -	port->try_src_count = 0;
> > > -	port->try_snk_count = 0;
> > > -
> > >  	if (!port->attached)
> > >  		return;
> > >  
> > > -- 
> > > 2.43.0
> > > 
> > > 
> > 
> > Hi,
> > 
> > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > a patch that has triggered this response.  He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created.  Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> > 
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> > 
> > - Your patch does not have a Signed-off-by: line.  Please read the
> >   kernel file, Documentation/process/submitting-patches.rst and resend
> >   it after adding that line.  Note, the line needs to be in the body of
> >   the email, before the patch, not at the bottom of the patch or in the
> >   email signature.
> > 
> > 
> > If you wish to discuss this problem further, or you have questions about
> > how to resolve this issue, please feel free to respond to this email and
> > Greg will reply once he has dug out from the pending patches received
> > from other developers.
> 
> It's a mechanically generated revert of upstream patch. It has no authorship.
> I did not write it, machine did. :)
> 
> But I can add a sign off for the commit message I made:
> 
> Signed-of-by: Ondrej Jirman <megi@xff.cz>

You have to do so.

And you need a Fixes: and cc: stable tag too, right?

Please fix up and send a v2 properly.

thanks,

greg k-h

Re: [PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

[Guenter Roeck]

On 2/17/24 08:03, Greg Kroah-Hartman wrote:

>> It's a mechanically generated revert of upstream patch. It has no authorship.
>> I did not write it, machine did. :)
>>
>> But I can add a sign off for the commit message I made:
>>
>> Signed-of-by: Ondrej Jirman <megi@xff.cz>
> 
> You have to do so.
> 

It is not a valid argument to start with. "git revert" has
a "-s" option to sign reverts for that very purpose.

Guenter

[PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

[Ondřej Jirman]

From: Ondrej Jirman <megi@xff.cz>

The reverted commit makes the state machine only ever go from SRC_ATTACH_WAIT
to SNK_TRY in endless loop when toggling. After revert it goes to SRC_ATTACHED
after initially trying SNK_TRY earlier, as it should for toggling to ever detect
the power source mode and the port is again able to provide power to attached
power sinks.

This reverts commit 2d6d80127006ae3da26b1f21a65eccf957f2d1e5.

Cc: stable@vger.kernel.org
Fixes: 2d6d80127006 ("usb: typec: tcpm: reset counter when enter into unattached state after try role")
Signed-of-by: Ondrej Jirman <megi@xff.cz>
---
 drivers/usb/typec/tcpm/tcpm.c | 3 ---
 1 file changed, 3 deletions(-)

See https://lore.kernel.org/all/odggrbbgjpardze76qiv57mw6tllisyu5sbrta37iadjzwamcv@qr3ubwnlzqqt/
for more.

diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index f7d7daa60c8d..295ae7eb912c 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -3743,9 +3743,6 @@ static void tcpm_detach(struct tcpm_port *port)
 	if (tcpm_port_is_disconnected(port))
 		port->hard_reset_count = 0;
 
-	port->try_src_count = 0;
-	port->try_snk_count = 0;
-
 	if (!port->attached)
 		return;
 
-- 
2.43.0

Re: [PATCH] Revert "usb: typec: tcpm: reset counter when enter into unattached state after try role"

[Heikki Krogerus]

On Sat, Feb 17, 2024 at 05:20:21PM +0100, Ondřej Jirman wrote:
> From: Ondrej Jirman <megi@xff.cz>
> 
> The reverted commit makes the state machine only ever go from SRC_ATTACH_WAIT
> to SNK_TRY in endless loop when toggling. After revert it goes to SRC_ATTACHED
> after initially trying SNK_TRY earlier, as it should for toggling to ever detect
> the power source mode and the port is again able to provide power to attached
> power sinks.
> 
> This reverts commit 2d6d80127006ae3da26b1f21a65eccf957f2d1e5.
> 
> Cc: stable@vger.kernel.org
> Fixes: 2d6d80127006 ("usb: typec: tcpm: reset counter when enter into unattached state after try role")
> Signed-of-by: Ondrej Jirman <megi@xff.cz>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> See https://lore.kernel.org/all/odggrbbgjpardze76qiv57mw6tllisyu5sbrta37iadjzwamcv@qr3ubwnlzqqt/
> for more.
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index f7d7daa60c8d..295ae7eb912c 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -3743,9 +3743,6 @@ static void tcpm_detach(struct tcpm_port *port)
>  	if (tcpm_port_is_disconnected(port))
>  		port->hard_reset_count = 0;
>  
> -	port->try_src_count = 0;
> -	port->try_snk_count = 0;
> -
>  	if (!port->attached)
>  		return;
>  
> -- 
> 2.43.0

-- 
heikki