* [PATCH] usb: typec: ucsi: fix UCSI on SM8550 & SM8650 Qualcomm devices
@ 2024-02-23 9:40 Neil Armstrong
2024-02-26 8:44 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Neil Armstrong @ 2024-02-23 9:40 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, linux-arm-msm, Neil Armstrong
On SM8550 and SM8650 Qualcomm platforms a call to UCSI_GET_PDOS for
non-PD partners will cause a firmware crash with no
easy way to recover from it.
Add UCSI_NO_PARTNER_PDOS quirk for those platform until we find
a way to properly handle the crash.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/usb/typec/ucsi/ucsi_glink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c
index 0bd3f6dee678..932e7bf69447 100644
--- a/drivers/usb/typec/ucsi/ucsi_glink.c
+++ b/drivers/usb/typec/ucsi/ucsi_glink.c
@@ -302,6 +302,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = {
{ .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
{ .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
{ .compatible = "qcom,sm8350-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
+ { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
{}
};
---
base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276
change-id: 20240223-topic-sm8550-upstream-ucsi-no-pdos-62fdad669f90
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: typec: ucsi: fix UCSI on SM8550 & SM8650 Qualcomm devices
2024-02-23 9:40 [PATCH] usb: typec: ucsi: fix UCSI on SM8550 & SM8650 Qualcomm devices Neil Armstrong
@ 2024-02-26 8:44 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2024-02-26 8:44 UTC (permalink / raw)
To: Neil Armstrong; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, linux-arm-msm
On Fri, Feb 23, 2024 at 10:40:40AM +0100, Neil Armstrong wrote:
> On SM8550 and SM8650 Qualcomm platforms a call to UCSI_GET_PDOS for
> non-PD partners will cause a firmware crash with no
> easy way to recover from it.
>
> Add UCSI_NO_PARTNER_PDOS quirk for those platform until we find
> a way to properly handle the crash.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/ucsi_glink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c
> index 0bd3f6dee678..932e7bf69447 100644
> --- a/drivers/usb/typec/ucsi/ucsi_glink.c
> +++ b/drivers/usb/typec/ucsi/ucsi_glink.c
> @@ -302,6 +302,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = {
> { .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
> { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
> { .compatible = "qcom,sm8350-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
> + { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)UCSI_NO_PARTNER_PDOS, },
> {}
> };
>
>
> ---
> base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276
> change-id: 20240223-topic-sm8550-upstream-ucsi-no-pdos-62fdad669f90
>
> Best regards,
> --
> Neil Armstrong <neil.armstrong@linaro.org>
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-23 9:40 [PATCH] usb: typec: ucsi: fix UCSI on SM8550 & SM8650 Qualcomm devices Neil Armstrong
2024-02-26 8:44 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox