Re: CVE-2023-52451: powerpc/pseries/memhp: Fix access beyond end of drmem array

Greg Kroah-Hartman
2024-02-29T08:35:31Z

On Thu, Feb 29, 2024 at 09:22:51AM +0100, Michal Hocko wrote:
> On Wed 28-02-24 09:12:15, Kees Cook wrote:
> > On Wed, Feb 28, 2024 at 01:04:14PM +0100, Michal Hocko wrote:
> > > On Tue 27-02-24 10:35:40, Kees Cook wrote:
> > > > On Mon, Feb 26, 2024 at 04:25:09PM +0100, Michal Hocko wrote:
> > > [...]
> > > > > Does that mean that any potentially incorrect input provided by an admin is
> > > > > considered CVE now?
> > > >
> > > > Yes. Have you seen what USER_NS does? There isn't a way to know how
> > > > deployments are using Linux, and this is clearly a "weakness" as defined
> > > > by CVE. It is better to be over zealous than miss things.
> > >
> > > If we are over zealous to the point when almost any fix is marked CVE
> > > then the special marking simply stops making any sense IMHO.
> >
> > Perhaps, but the volume of fixes is high, and I think it's better to
> > over estimate than under estimate -- the work needed to actually
> > evaluate all these changes is huge: it's better to take everything from
> > -stable.
>
> This is simply not feasible for many downstream kernels and reasons have
> been discussed many times.

How does taking 10 patches differ from taking 200 patches? Your
testing/infrastructure issues should be the same, right?

And really, if you have the crazy requirement of "All CVEs must be
applied" then perhaps that needs to be revisited? You are dictating
your business's processes to an external entity, is that wise? And if
it is wise, why are you not able to handle it today? Making it simpler
for you to consume these entries seems to be a better decision. With
the changes we have made, you should be able to automatically determine
if you are affected or not, which is something that you did NOT have
before, so this might just be able to be automated, right?

> > This has been a long standing problem with communicating this
> > to engineering management in many organizations. They have pointed to
> > the relatively small number of CVEs and said, "just backport those
> > fixes", and trying to explain that it's is totally insufficient falls on
> > deaf ears.
>
> I think it is fair to say/expect that every downstream is responsibile
> for the kernel they are distributing and that applies to vulnerabilities
> affecting those kernels. Forcing fixes by slapping CVE over them sounds
> just very dubious to me.

Not having CVEs assigned for things that can cause issues is dubious,
which is why we are doing this. We can not determine use cases of our
code base, that is up to you as a distro to figure out, all we can do is
our best to call out "This might be something you want to take!" which
is what we are doing here.

Remember, we KNOW that people have been scraping our commit logs for
these types of things and using them in attacks for years. At least
this way we are giving you a machine-parsable feed that gives you the
opportunity to make your kernels more secure than they previously were.

Why is that not a good thing?

thanks,

greg k-h