From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C4B8EDB for ; Mon, 11 Mar 2024 02:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710123433; cv=none; b=ElYn+r+8Pplh9dtrXGXdxUspR+ydDio7oima7BFT8cU2I6xFqTu/d/cfd2QFweckIyrvnG32pm6Rz0NqyOv/WssAFjA6DMDPUdpj/J2L9WD3euIMi0ieKg8IatuMyc46rzeFHW2DfnF1LcI23xUDATzyuURoXEz9QIhkxL0L94w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710123433; c=relaxed/simple; bh=1L7MoSZFuvPSNtlP8t+DsIgAFz3OYQfQmtdX/FZeVDI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OZbbD70lnA1r7CCGi7bchajr0jG0BMlvJaQ0KstGj7KObjdR6IaSjxeRHpgirokpta8dPGM64quSK/AtIymO11Akmgn5HrNYbEqYIg+0sCBsbXLJWMh//VNI7sF22GnaWV7TZ0bgvwinemeDkYOwyiJsDYUO4E5CWpXvnvQA0Ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=jCk0db+n; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="jCk0db+n" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-29b7b9a4908so1366950a91.1 for ; Sun, 10 Mar 2024 19:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1710123431; x=1710728231; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=P2HOPvTzIOfPgTuaGyDXCX6Oprhe2Q5xowyCchEBaBY=; b=jCk0db+nO/Lk+OXykEwsQIfoYn/mAi0EHmQXCu1T3dBwlf9+KTQiLrby5GBp93j7U7 V5ghmYNvale5vaOcsnZ+1He+O8nnGePtL2AI9KIg8S++ZwY4GcGyJtBjqF6y7n8hL4sD j46+YkXWN7Dv4S2FZm/DzLh46ak9YXGD+5wmbWSDv54w8oWWDrNLs6RfrvlbBdOv9kg4 5sc4C5KzOT89NoK6Y3b2z4gB397PO7ySMlN4Qmk9wXAxMlTfgceg4KFbcfsxr79qz1Zx rtEI2xQihYLAwHnQH6V5mtU2k1CinLV/rS4y+0Pdh0uVG84aHteeiyNLpTxFKUctBVSb 6Otg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710123431; x=1710728231; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P2HOPvTzIOfPgTuaGyDXCX6Oprhe2Q5xowyCchEBaBY=; b=GQUYsarHndmbgZiTbCROkRMSvsqKVNtrXcu7jhZKlqPAiIYhf6aCHDI3ctmuCVsOeX RVymu9Y7GSwLPTrp7LpN0QrpFbta986fY2QwXRo+o1gRIhQJ6NdkoLBpVDdXf03+Rktj TQqeg5ajhXXdqdtp+FjigzM7o+TT54+dmmEDcYMr8TkgOkaJLCSnTm52uoMaLppHRICd YDGezPABGLevm4IOQB3qBeRNHqc3wes8wQpueEY+rmAftCM8wW2bIIkMbatPdcFuBott jH2Qq3OM7m9usJd98GIEnS6FdIVDToCp27b2BwE0hKcfl1YMzXYS3Pd2dboXs0Uvhyyd kGPQ== X-Forwarded-Encrypted: i=1; AJvYcCUBobVLsLozKyYsbetZjVINDI4Sp8E3yVZxSZCJkUjru3JXqXM0NJCDVQgI5uAIpJMD9GgKLtLJTzwgTLDUsobjLnxYj9YLiZAAfDE8 X-Gm-Message-State: AOJu0YwHfQkwp1Eu57beam7xqEu0L4gLRE9oG9MegiYyYTieaEh+1Cm3 zobrJ86RObn8o5cA6n8Lp1pF+UcTQ0cM1JGUqNqQX9Rt7+6+6WDtSIPq8Ne3fC8= X-Google-Smtp-Source: AGHT+IEgtGW5AN8mnjwdibd+gLuySW0tEDIBlzlkkIrMs8fV0hgNTvd0J7PfU9RiDNuMx2cvGySV0Q== X-Received: by 2002:a17:90a:f417:b0:299:a69:1f8b with SMTP id ch23-20020a17090af41700b002990a691f8bmr3199478pjb.23.1710123431284; Sun, 10 Mar 2024 19:17:11 -0700 (PDT) Received: from dread.disaster.area (pa49-179-47-118.pa.nsw.optusnet.com.au. [49.179.47.118]) by smtp.gmail.com with ESMTPSA id p3-20020a17090a348300b0029bc1c931d9sm3752893pjb.51.2024.03.10.19.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 19:17:10 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rjVDw-000GCA-1X; Mon, 11 Mar 2024 13:17:08 +1100 Date: Mon, 11 Mar 2024 13:17:08 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: Kent Overstreet , Neal Gompa , linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Josef Bacik , Miklos Szeredi , Christian Brauner , David Howells Subject: Re: [PATCH v2] statx: stx_subvol Message-ID: References: <20240308022914.196982-1-kent.overstreet@linux.dev> <2uk6u4w7dp4fnd3mrpoqybkiojgibjodgatrordacejlsxxmxz@wg5zymrst2td> <20240308165633.GO6184@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308165633.GO6184@frogsfrogsfrogs> On Fri, Mar 08, 2024 at 08:56:33AM -0800, Darrick J. Wong wrote: > Should the XFS data and rt volumes be reported with different stx_vol > values? No, because all the inodes are on the data volume and the same inode can have data on the data volume or the rt volume. i.e. "data on rt, truncate, clear rt, copy data back into data dev". It's still the same inode, and may have exactly the same data, so why should change stx_vol and make it appear to userspace as being a different inode? -Dave. -- Dave Chinner david@fromorbit.com