public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: francisco_flynn <francisco_flynn@foxmail.com>
Cc: dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org,  tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, x86@kernel.org,  hpa@zytor.com,
	rdunlap@infradead.org, akpm@linux-foundation.org,
	 bhelgaas@google.com, mawupeng1@huawei.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: treat WC memory as MMIO
Date: Mon, 11 Mar 2024 09:20:03 -0700	[thread overview]
Message-ID: <Ze8vM6HcU4vnXVSS@google.com> (raw)
In-Reply-To: <tencent_4B50D08D2E6211E4F9B867F0531F2C05BA0A@qq.com>

On Mon, Mar 11, 2024, francisco_flynn wrote:
> when doing kvm_tdp_mmu_map for WC memory, such as pages
> allocated by amdgpu ttm driver for ttm_write_combined
> caching mode(e.g. host coherent in vulkan),
> the spte would be set to WB, in this case, vcpu write
> to these pages would goes to cache first, and never
> be write-combined and host-coherent anymore. so
> WC memory should be treated as MMIO, and the effective
> memory type is depending on guest PAT.

No, the effective memtype is not fully guest controlled.  By forcing the EPT memtype
to UC, the guest can only use UC or WC.  I don't know if there's a use case for
the host mapping memory WC while the guest uses WB, but it should be a moot point,
because this this series should do what you want (allow guest to map GPU buffers
as WC).

https://lore.kernel.org/all/20240309010929.1403984-1-seanjc@google.com

> Signed-off-by: francisco_flynn <francisco_flynn@foxmail.com>
> ---
>  arch/x86/include/asm/memtype.h | 2 ++
>  arch/x86/kvm/mmu/spte.c        | 5 +++--

Please use get_maintainers.pl.

>  arch/x86/mm/pat/memtype.c      | 8 ++++++++
>  3 files changed, 13 insertions(+), 2 deletions(-)

  reply	other threads:[~2024-03-11 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 10:47 [PATCH] KVM: x86/mmu: treat WC memory as MMIO francisco_flynn
2024-03-11 16:20 ` Sean Christopherson [this message]
2024-03-12  8:42   ` francisco flynn
2024-03-12 15:21     ` Sean Christopherson
2024-03-13  2:01       ` francisco flynn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ze8vM6HcU4vnXVSS@google.com \
    --to=seanjc@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=francisco_flynn@foxmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mawupeng1@huawei.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox