[PATCH] spmi: hisi-spmi-controller: Do not override device identifier

[PATCH] spmi: hisi-spmi-controller: Do not override device identifier

[Vamshi Gajjela]

'nr' member of struct spmi_controller, which serves as an identifier
for the controller/bus. This value is a dynamic ID assigned in
spmi_controller_alloc, and overriding it from the driver results in an
ida_free error "ida_free called for id=xx which is not allocated".

Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
Cc: stable@vger.kernel.org
---
 drivers/spmi/hisi-spmi-controller.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
index 674a350cc676..fa068b34b040 100644
--- a/drivers/spmi/hisi-spmi-controller.c
+++ b/drivers/spmi/hisi-spmi-controller.c
@@ -300,7 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev)
 
 	spin_lock_init(&spmi_controller->lock);
 
-	ctrl->nr = spmi_controller->channel;
 	ctrl->dev.parent = pdev->dev.parent;
 	ctrl->dev.of_node = of_node_get(pdev->dev.of_node);
 
-- 
2.44.0.rc1.240.g4c46232300-goog

Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier

[Johan Hovold]

On Thu, Feb 29, 2024 at 12:21:16AM +0530, Vamshi Gajjela wrote:
> 'nr' member of struct spmi_controller, which serves as an identifier
> for the controller/bus. This value is a dynamic ID assigned in
> spmi_controller_alloc, and overriding it from the driver results in an
> ida_free error "ida_free called for id=xx which is not allocated".
> 
> Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> Cc: stable@vger.kernel.org
> ---

This is v2, which should be indicated in the patch subject and with a
short changelog here (e.g. mentioning the split and rebase on 6.8-rc).

Johan

Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier

[VAMSHI GAJJELA]

On Thu, Feb 29, 2024 at 1:38 PM Johan Hovold <johan@kernel.org> wrote:
>
> On Thu, Feb 29, 2024 at 12:21:16AM +0530, Vamshi Gajjela wrote:
> > 'nr' member of struct spmi_controller, which serves as an identifier
> > for the controller/bus. This value is a dynamic ID assigned in
> > spmi_controller_alloc, and overriding it from the driver results in an
> > ida_free error "ida_free called for id=xx which is not allocated".
> >
> > Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> > Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> > Cc: stable@vger.kernel.org
> > ---
>
> This is v2, which should be indicated in the patch subject and with a
> short changelog here (e.g. mentioning the split and rebase on 6.8-rc).
ack, Thanks
>
> Johan

Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier

[Stephen Boyd]

Quoting Vamshi Gajjela (2024-02-28 10:51:16)
> 'nr' member of struct spmi_controller, which serves as an identifier
> for the controller/bus. This value is a dynamic ID assigned in
> spmi_controller_alloc, and overriding it from the driver results in an
> ida_free error "ida_free called for id=xx which is not allocated".
> 
> Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> Cc: stable@vger.kernel.org
> ---

Applied to spmi-next