* [PATCH] spmi: hisi-spmi-controller: Do not override device identifier
@ 2024-02-28 18:51 Vamshi Gajjela
2024-02-29 8:08 ` Johan Hovold
2024-04-08 3:29 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Vamshi Gajjela @ 2024-02-28 18:51 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Stephen Boyd, Johan Hovold
Cc: Caleb Connolly, linux-kernel, stable, Vamshi Gajjela
'nr' member of struct spmi_controller, which serves as an identifier
for the controller/bus. This value is a dynamic ID assigned in
spmi_controller_alloc, and overriding it from the driver results in an
ida_free error "ida_free called for id=xx which is not allocated".
Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
Cc: stable@vger.kernel.org
---
drivers/spmi/hisi-spmi-controller.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
index 674a350cc676..fa068b34b040 100644
--- a/drivers/spmi/hisi-spmi-controller.c
+++ b/drivers/spmi/hisi-spmi-controller.c
@@ -300,7 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev)
spin_lock_init(&spmi_controller->lock);
- ctrl->nr = spmi_controller->channel;
ctrl->dev.parent = pdev->dev.parent;
ctrl->dev.of_node = of_node_get(pdev->dev.of_node);
--
2.44.0.rc1.240.g4c46232300-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier
2024-02-28 18:51 [PATCH] spmi: hisi-spmi-controller: Do not override device identifier Vamshi Gajjela
@ 2024-02-29 8:08 ` Johan Hovold
2024-03-05 9:16 ` VAMSHI GAJJELA
2024-04-08 3:29 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2024-02-29 8:08 UTC (permalink / raw)
To: Vamshi Gajjela
Cc: Mauro Carvalho Chehab, Stephen Boyd, Johan Hovold, Caleb Connolly,
linux-kernel, stable
On Thu, Feb 29, 2024 at 12:21:16AM +0530, Vamshi Gajjela wrote:
> 'nr' member of struct spmi_controller, which serves as an identifier
> for the controller/bus. This value is a dynamic ID assigned in
> spmi_controller_alloc, and overriding it from the driver results in an
> ida_free error "ida_free called for id=xx which is not allocated".
>
> Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> Cc: stable@vger.kernel.org
> ---
This is v2, which should be indicated in the patch subject and with a
short changelog here (e.g. mentioning the split and rebase on 6.8-rc).
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier
2024-02-29 8:08 ` Johan Hovold
@ 2024-03-05 9:16 ` VAMSHI GAJJELA
0 siblings, 0 replies; 4+ messages in thread
From: VAMSHI GAJJELA @ 2024-03-05 9:16 UTC (permalink / raw)
To: Johan Hovold
Cc: Mauro Carvalho Chehab, Stephen Boyd, Johan Hovold, Caleb Connolly,
linux-kernel, stable
On Thu, Feb 29, 2024 at 1:38 PM Johan Hovold <johan@kernel.org> wrote:
>
> On Thu, Feb 29, 2024 at 12:21:16AM +0530, Vamshi Gajjela wrote:
> > 'nr' member of struct spmi_controller, which serves as an identifier
> > for the controller/bus. This value is a dynamic ID assigned in
> > spmi_controller_alloc, and overriding it from the driver results in an
> > ida_free error "ida_free called for id=xx which is not allocated".
> >
> > Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> > Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> > Cc: stable@vger.kernel.org
> > ---
>
> This is v2, which should be indicated in the patch subject and with a
> short changelog here (e.g. mentioning the split and rebase on 6.8-rc).
ack, Thanks
>
> Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier
2024-02-28 18:51 [PATCH] spmi: hisi-spmi-controller: Do not override device identifier Vamshi Gajjela
2024-02-29 8:08 ` Johan Hovold
@ 2024-04-08 3:29 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2024-04-08 3:29 UTC (permalink / raw)
To: Johan Hovold, Mauro Carvalho Chehab, Vamshi Gajjela
Cc: Caleb Connolly, linux-kernel, stable, Vamshi Gajjela
Quoting Vamshi Gajjela (2024-02-28 10:51:16)
> 'nr' member of struct spmi_controller, which serves as an identifier
> for the controller/bus. This value is a dynamic ID assigned in
> spmi_controller_alloc, and overriding it from the driver results in an
> ida_free error "ida_free called for id=xx which is not allocated".
>
> Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> Cc: stable@vger.kernel.org
> ---
Applied to spmi-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-08 3:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-28 18:51 [PATCH] spmi: hisi-spmi-controller: Do not override device identifier Vamshi Gajjela
2024-02-29 8:08 ` Johan Hovold
2024-03-05 9:16 ` VAMSHI GAJJELA
2024-04-08 3:29 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox