From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mateusz Pacuszka <mateuszx.pacuszka@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Lukasz Plachno <lukasz.plachno@intel.com>,
Jakub Buchocki <jakubx.buchocki@intel.com>,
Pawel Kaminski <pawel.kaminski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pawel Chmielewski <pawel.chmielewski@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH iwl-net 0/5] ice: LLDP support for VFs
Date: Thu, 29 Feb 2024 10:20:05 +0100 [thread overview]
Message-ID: <ZeBMRXUjVSwUHxU-@nanopsycho> (raw)
In-Reply-To: <20240228084745.2c0fef0e@kernel.org>
Wed, Feb 28, 2024 at 05:47:45PM CET, kuba@kernel.org wrote:
>On Wed, 28 Feb 2024 16:59:44 +0100 Larysa Zaremba wrote:
>> Allow to:
>> * receive LLDP packets on a VF
>> * transmit LLDP from a VF
>>
>> Only a single VF per port can transmit LLDP packets,
>> all trusted VFs can transmit LLDP packets.
>>
>> For both functionalities to work, private flag
>> fw-lldp-agent must be off.
>>
>> I am aware that implemented way of configuration (through sysfs) can be
>> potentially controversial and would like some feedback from outside.
>
>Why is the device not in switchdev mode? You can put your lldp-agent
>priv flag on repr netdevs.
>
But isn't it a matter of eswitch configuration? I mean, the user should
be free to configure filtering/forwarding of any packet, including LLDP
ones.
next prev parent reply other threads:[~2024-02-29 9:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 15:59 [PATCH iwl-net 0/5] ice: LLDP support for VFs Larysa Zaremba
2024-02-28 15:59 ` [PATCH iwl-net 1/5] ice: Add function to get VF from device struct Larysa Zaremba
2024-02-28 15:59 ` [PATCH iwl-net 2/5] ice: Fix check for existing switch rule Larysa Zaremba
2024-02-28 15:59 ` [PATCH iwl-net 3/5] ice: Do not add LLDP-specific filter Larysa Zaremba
2024-02-28 15:59 ` [PATCH iwl-net 4/5] ice: Implement VF LLDP RX support on VF Larysa Zaremba
2024-02-29 9:12 ` Jiri Pirko
2024-02-28 15:59 ` [PATCH iwl-net 5/5] ice: Implement VF LLDP TX support for VF Larysa Zaremba
2024-02-28 16:47 ` [PATCH iwl-net 0/5] ice: LLDP support for VFs Jakub Kicinski
2024-02-29 9:20 ` Jiri Pirko [this message]
2024-02-29 15:28 ` Jakub Kicinski
2024-02-29 19:33 ` Larysa Zaremba
2024-03-01 17:08 ` Jakub Kicinski
2024-03-02 0:50 ` Larysa Zaremba
2024-03-05 19:54 ` Jakub Kicinski
2024-03-02 6:47 ` Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeBMRXUjVSwUHxU-@nanopsycho \
--to=jiri@resnulli.us \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakubx.buchocki@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.plachno@intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=mateuszx.pacuszka@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pawel.chmielewski@intel.com \
--cc=pawel.kaminski@intel.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox