From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C91477A125; Thu, 29 Feb 2024 20:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709236847; cv=none; b=O7Jo/jdfRjVlVbiBVBx+FbtWlcxA4ppy2XE8dPdI/mcCPgwzcje42/L+tKz/WXnypFaez39pZGnd2hxh6eadG7mdhwxWp8RaUwBH8HXQ7D6Ad5MJ2ZfTjVS3KJXLcyTa4jEdhzAvNips+7RP54Rx1YgrEwK3ppsKcHKLNuolE0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709236847; c=relaxed/simple; bh=pgMPjnzpWVwWRax5G9fKHRUUN5IDvl4E8Lqx/QZdIyg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TVTUL59uxV1CE6szegIC3tXYRey9Mj8UjSYSE5I1RCX+beB8ypyh/dzCIT2XJuVT59F5dA1zixix/uEVGVnDHCknzX/AbIFP9nCd3Fp2UoAPx1vdacUrUpmeO8ebTbpa62eGRIq5wXH+AFc2WeXaigJXgfUAoMy9Bfo3ksFqxcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZOtieByr; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZOtieByr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709236846; x=1740772846; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pgMPjnzpWVwWRax5G9fKHRUUN5IDvl4E8Lqx/QZdIyg=; b=ZOtieByr5ATnyeWbDDZNXYNcuY1EKzMZ7MNGtb5wJ7AS/EZ7FappYSQd LLxSKjeEQYp/Fg8N/Z0rDmI0rhYBlHx/oK1eFKYJ2Sm5hihaXCltClz9v 8+0HLzDDiGqpCuApERqcNkkt9srbHbQnvIWNlHbGKn5asYGYXvN4EyNPQ vLHsRXSmg01RC+4Jy1+3+0FQNL/EvyA8WTApPifEr14k2cmt6Otz/BlNY Vgv/ccEezonpqBt5OE7JgAQmMMClppNn3c1RxcIcKaL3IHJs8E8PNdYGv RQKNysq4XX/bPZa8JRdgCFmNq2u6qn/OzzEXuzNasT9DOPvwmrcVqeHRx g==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="14376081" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="14376081" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 12:00:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="913991086" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="913991086" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 12:00:42 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rfma6-00000008m8s-3tH6; Thu, 29 Feb 2024 22:00:38 +0200 Date: Thu, 29 Feb 2024 22:00:38 +0200 From: Andy Shevchenko To: Kees Cook Cc: "David S. Miller" , Andreas Larsson , Masahiro Yamada , Sam Ravnborg , Helge Deller , Guo Ren , sparclinux@vger.kernel.org, Catalin Marinas , "Russell King (Oracle)" , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] sparc: vdso: Disable UBSAN instrumentation Message-ID: References: <20240223165942.work.950-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223165942.work.950-kees@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Feb 23, 2024 at 08:59:45AM -0800, Kees Cook wrote: > The UBSAN instrumentation cannot work in the vDSO since it is executing > in userspace, so disable it in the Makefile. Fixes the build failures > such as: > > arch/sparc/vdso/vclock_gettime.c:217: undefined reference to `__ubsan_handle_shift_out_of_bounds' > > Signed-off-by: Kees Cook > --- > Cc: "David S. Miller" > Cc: Andreas Larsson > Cc: Masahiro Yamada > Cc: Sam Ravnborg > Cc: Helge Deller > Cc: Guo Ren > Cc: sparclinux@vger.kernel.org I dunno how you applied patches, but these Cc seems to appear in a few commits in your hardening branch. I formatted patch from 9fd54b08040669, checked out the new branch just before this commit and run `git am 0001-...`. I don't see them. -- With Best Regards, Andy Shevchenko