From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA4B42570 for ; Fri, 1 Mar 2024 00:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709253605; cv=none; b=fcS/FM5xhcKuplQ5mb6PWbidgKOOcexpbL8J8EK38q4L33LgdnInzCdaT7LTCQNZqnSjLt8Y9MV5GejAlSvpwyKLnrkBSWc0Ao/ZjHFlBb6JJs/c7J4/bpL2hGgdjty/FUlnX4NLYrKgHzgR9S1bYGZ/K529Ft7wgCsSVoxED+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709253605; c=relaxed/simple; bh=lYtLzPPW/z966kwacpoZ8g46ZAY0gZ9kGfAS51bcavA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AZgY84JA2fW1PqOn+buOqbY3pCwsoX3mS2XYhtvlxIxyeSg9iJO4vehPk+ox/+w0v8oU7XXJKYG+EmobKbEqm7yxCrIHaUNSao5FZ7vI1fZ7TBU8cmFd3Vfqh+kqzklf7uKCaEAntwEem6enOn2nxv2ZMpviTwNRGWrmV+QeTZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=TpVOeK+l; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="TpVOeK+l" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-412bcb76703so9368415e9.2 for ; Thu, 29 Feb 2024 16:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1709253602; x=1709858402; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gV3niUCTSl6gtqi0cGOEMe9/Tm7btRuQ6YcO62YSGhA=; b=TpVOeK+lHsDCaPIgpWWlgKq8I5D9ULKCn0+69/2RxVQWBY03TyOlQ1iFQkiZYepVN5 3oJODlcOc6vbtNjp9FL9JsRDCOjbU1uaBxxAVtxAIIpKpKuOpTmCoRdV9wArYE1ZF5y0 HRXGjnC+vy3XRcdVCJJm57YRjm9YmgP5ZA9oI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709253602; x=1709858402; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gV3niUCTSl6gtqi0cGOEMe9/Tm7btRuQ6YcO62YSGhA=; b=V9ehRO6lOimfSb52m55FeqquL1TVKusnWwLorEL3ygvBrAj4o0HpjeCbj9I6T6bixd kL2tcf68vmQjtYZ87IS1I3tz5LNVZwsDKcd2Zyos4k8jEhQsM/L2puB2Sy27qOo/UGMl aphVBOhvipf6IGi6kxLMrkY92T6DMEz3RHLMQAFwddlED/d0U2rPmt1nj6lCRaPneWCv Fk5I9Ofk00T3L68TqlCk+5mVwcAJLao+vCo8YYRVA73zP+KGdorPnyZJ3sGIIoz1Fput xp42/QZ0HJ1rCCK4fPQb3c3XesLO9ecVdORLqjs556E9ejWPx12O1jF/z5M/U0qAkz6B pz3w== X-Forwarded-Encrypted: i=1; AJvYcCVwO0rIjknSTIZNgVnaLfXcqz1wWIHWa6rvkeOKKKYc6DVsJJ4p0o0tps89R3SM/YyD39aHTzbxP0ssgTiQuM98tDUp4kgvel2l5+ZO X-Gm-Message-State: AOJu0YyeFkQx+dc8Xj5cZpdQB/nTNVhA0R6PNUrjok+sH5njU/6QFkrX g70rzkK8GgXBBbNmqdUs45fcJwD/jMYyX0c0yoz8JOI+Fmsw43yKPP65SxTRulY= X-Google-Smtp-Source: AGHT+IEwfmcug1aTGUzafnFeCI/ObU1i6mZjItOY64bGc42eoE1907pWp003h6IR5J7XGh1bi4umjA== X-Received: by 2002:a05:600c:4f0d:b0:412:beee:36b3 with SMTP id l13-20020a05600c4f0d00b00412beee36b3mr185074wmq.7.1709253602157; Thu, 29 Feb 2024 16:40:02 -0800 (PST) Received: from localhost ([93.115.193.42]) by smtp.gmail.com with ESMTPSA id f15-20020adffccf000000b0033dedd63382sm3045765wrs.101.2024.02.29.16.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:40:01 -0800 (PST) Date: Fri, 1 Mar 2024 00:40:01 +0000 From: Chris Down To: Geert Uytterhoeven Cc: Petr Mladek , Greg Kroah-Hartman , Andy Shevchenko , Jessica Yu , Steven Rostedt , John Ogness , Sergey Senozhatsky , Jason Baron , Jim Cromie , Ilya Dryomov , Xiubo Li , Jeff Layton , linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org Subject: Re: [PATCH net-next] Simplify net_dbg_ratelimited() dummy Message-ID: References: <5d75ce122b5cbfe62b018a7719960e34cfcbb1f2.1709128975.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <5d75ce122b5cbfe62b018a7719960e34cfcbb1f2.1709128975.git.geert+renesas@glider.be> User-Agent: Mutt/2.2.12 (2023-09-09) Geert Uytterhoeven writes: >There is no need to wrap calls to the no_printk() helper inside an >always-false check, as no_printk() already does that internally. > >Signed-off-by: Geert Uytterhoeven In the context of the larger printk index changes: Acked-by: Chris Down >--- > include/linux/net.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/include/linux/net.h b/include/linux/net.h >index c9b4a63791a45948..15df6d5f27a7badc 100644 >--- a/include/linux/net.h >+++ b/include/linux/net.h >@@ -299,10 +299,7 @@ do { \ > net_ratelimited_function(pr_debug, fmt, ##__VA_ARGS__) > #else > #define net_dbg_ratelimited(fmt, ...) \ >- do { \ >- if (0) \ >- no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); \ >- } while (0) >+ no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) > #endif > > #define net_get_random_once(buf, nbytes) \ >-- >2.34.1 >