Re: [PATCH v3 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers

Frank Li
2024-03-01T04:04:03Z

On Thu, Feb 29, 2024 at 10:44:42AM +0100, Krzysztof Kozlowski wrote:
> On 28/02/2024 20:14, Frank Li wrote:
> > fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms
> > have 1 interrupt.
> >
> > Increase max interrupt number to 2 and add restriction for platforms except
> > i.MX8QXP and i.MX8QM.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > .../devicetree/bindings/sound/fsl,spdif.yaml | 20 +++++++++++++++++++-
> > 1 file changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> > index 82430f1d5e5a2..785f7997eea82 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> > @@ -31,7 +31,8 @@ properties:
> > maxItems: 1
> >
> > interrupts:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
> >
> > dmas:
> > items:
> > @@ -100,6 +101,23 @@ required:
> >
> > additionalProperties: false
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + enum:
> > + - fsl,imx35-spdif
> > + - fsl,vf610-spdif
> > + - fsl,imx6sx-spdif
> > + - fsl,imx8mq-spdif
> > + - fsl,imx8mm-spdif
> > + - fsl,imx8mn-spdif
> > + - fsl,imx8ulp-spdif
> > + then:
> > + properties:
> > + interrupts:
> > + maxItems: 1
>
> else:
> minItems: 2

I think needn't 'else' here. Top have set to maxItems is 2.

Frank

>
>
> Best regards,
> Krzysztof
>