Re: [PATCH v3 1/4] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains requirement

Frank Li
2024-03-04T15:39:49Z

On Mon, Mar 04, 2024 at 04:05:07PM +0100, Krzysztof Kozlowski wrote:
> On 01/03/2024 16:42, Frank Li wrote:
> > On Fri, Mar 01, 2024 at 07:30:10AM +0100, Krzysztof Kozlowski wrote:
> >> On 01/03/2024 05:01, Frank Li wrote:
> >>> On Thu, Feb 29, 2024 at 10:44:20AM +0100, Krzysztof Kozlowski wrote:
> >>>> On 28/02/2024 20:14, Frank Li wrote:
> >>>>> Add power-domains property for asrc and spdif.
> >>>>
> >>>> Why?
> >>>
> >>> i.MX8QXP i.MX8DXL and i.MX8QM need it.
> >>
> >> Where is it explained in the commit msg? What about other devices/variants?
> >
> > I will add it. These patches are for imx8qxp\imx8dxl\imx8qm only. If other
> > platform have problem, it should be fixed by new patch.
>
> I would assume more responsible approach from NXP, not just "their
> problem", but anyway that's not what the comment is. Why do you say all
> the variants have power domains in one commit, but now in email says
> that they might not have? All your patches are vague in this aspect.

I am not means "their problem". What's I said is one patch just fix one
thing. If need additional fix, I can create a new patches. I have not said
all need power domains specifically. If there are some words that let me
think all variant need power domain, please let me where, I can improve it.

Frank
>
> Best regards,
> Krzysztof
>