public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] string: Convert selftest to KUnit
Date: Fri, 1 Mar 2024 19:29:06 +0200	[thread overview]
Message-ID: <ZeIQYkRc_5lj6dd6@smile.fi.intel.com> (raw)
In-Reply-To: <202403010921.65C845411@keescook>

On Fri, Mar 01, 2024 at 09:25:07AM -0800, Kees Cook wrote:
> On Fri, Mar 01, 2024 at 01:09:27PM +0200, Andy Shevchenko wrote:
> > On Fri, Mar 1, 2024 at 2:26 AM Kees Cook <keescook@chromium.org> wrote:
> > >
> > > Convert test_string.c to KUnit so it can be easily run with everything
> > > else.
> > 
> > Have you run it?
> 
> Yes:

Of course I new the answer :-)

The problem as I described is the (absence of) fault injection in KUnit itself.
When tests are passed the picture is nice, when they are not, the reports become
a disaster (if this is applied).

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-03-01 17:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  0:26 [PATCH v2 0/2] string: Convert selftests to KUnit Kees Cook
2024-03-01  0:26 ` [PATCH v2 1/2] string: Convert selftest " Kees Cook
2024-03-01 11:09   ` Andy Shevchenko
2024-03-01 17:25     ` Kees Cook
2024-03-01 17:29       ` Andy Shevchenko [this message]
2024-03-01  0:26 ` [PATCH v2 2/2] string: Convert helpers " Kees Cook
2024-03-01 11:20   ` Andy Shevchenko
2024-03-01 20:29     ` Kees Cook
2024-03-01 11:22 ` [PATCH v2 0/2] string: Convert selftests " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeIQYkRc_5lj6dd6@smile.fi.intel.com \
    --to=andy.shevchenko@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox