public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Valentin Schneider <vschneid@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] sched/balancing: Change 'enum cpu_idle_type' to have more natural definitions
Date: Mon, 4 Mar 2024 10:26:09 +0100	[thread overview]
Message-ID: <ZeWTsTcK+3uvKeju@gmail.com> (raw)
In-Reply-To: <588d1af3-e619-414f-a26f-467ea51b4ab8@linux.ibm.com>


* Shrikanth Hegde <sshegde@linux.ibm.com> wrote:

> I think its all getting accounted. Just that its not being printed. With 
> the below change, able to see all the three types, albeit not in right 
> order as per schedstat documentation.
> 
> diff --git a/kernel/sched/stats.c b/kernel/sched/stats.c
> index 857f837f52cb..f36b54bdd9fa 100644
> --- a/kernel/sched/stats.c
> +++ b/kernel/sched/stats.c
> @@ -150,7 +150,7 @@ static int show_schedstat(struct seq_file *seq, void *v)
>  
>                         seq_printf(seq, "domain%d %*pb", dcount++,
>                                    cpumask_pr_args(sched_domain_span(sd)));
> -                       for (itype = CPU_IDLE; itype < CPU_MAX_IDLE_TYPES;
> +                       for (itype = 0; itype < CPU_MAX_IDLE_TYPES;
>                                         itype++) {
>                                 seq_printf(seq, " %u %u %u %u %u %u %u %u",
>                                     sd->lb_count[itype],

Indeed, good catch - there was an implicit reliance on CPU_IDLE's position 
in the loop above that my patch didn't take into account.

Fixed.

Thanks,

	Ingo

  reply	other threads:[~2024-03-04  9:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 11:09 [PATCH 0/7] sched/balancing: Misc updates & cleanups Ingo Molnar
2024-03-01 11:09 ` [PATCH 1/7] sched/balancing: Switch the 'DEFINE_SPINLOCK(balancing)' spinlock into an 'atomic_t sched_balance_running' flag Ingo Molnar
2024-03-01 15:35   ` Shrikanth Hegde
2024-03-04  9:24     ` Ingo Molnar
2024-03-01 11:09 ` [PATCH 2/7] sched/balancing: Change 'enum cpu_idle_type' to have more natural definitions Ingo Molnar
2024-03-02  9:04   ` Shrikanth Hegde
2024-03-04  9:26     ` Ingo Molnar [this message]
2024-03-01 11:09 ` [PATCH 3/7] sched/balancing: Change comment formatting to not overlap Git conflict marker lines Ingo Molnar
2024-03-01 11:09 ` [PATCH 4/7] sched/balancing: Fix comments (trying to) refer to NOHZ_BALANCE_KICK Ingo Molnar
2024-03-01 11:23   ` [PATCH 4/7 v2] " Ingo Molnar
2024-03-01 11:09 ` [PATCH 5/7] sched/balancing: Update run_rebalance_domains() comments Ingo Molnar
2024-03-01 11:26   ` [PATCH 5/7 v2] " Ingo Molnar
2024-03-01 11:09 ` [PATCH 6/7] sched/balancing: Vertically align the comments of 'struct sg_lb_stats' and 'struct sd_lb_stats' Ingo Molnar
2024-03-01 11:09 ` [PATCH 7/7] sched/balancing: Update comments in " Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeWTsTcK+3uvKeju@gmail.com \
    --to=mingo@kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=sshegde@linux.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox