From: Dominique Martinet <asmadeus@codewreck.org>
To: Eric Van Hensbergen <ericvh@kernel.org>
Cc: Colin Ian King <colin.i.king@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
v9fs@lists.linux.dev, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] fs/9p: remove redundant pointer v9ses
Date: Mon, 4 Mar 2024 21:59:22 +0900 [thread overview]
Message-ID: <ZeXFqt1NDp9sdz7n@codewreck.org> (raw)
In-Reply-To: <20240229222250.351322-1-colin.i.king@gmail.com>
Colin Ian King wrote on Thu, Feb 29, 2024 at 10:22:50PM +0000:
> Pointer v9ses is being assigned the value from the return of inlined
> function v9fs_inode2v9ses (which just returns inode->i_sb->s_fs_info).
> The pointer is not used after the assignment, so the variable is
> redundant and can be removed.
>
> Cleans up clang scan warnings such as:
> fs/9p/vfs_inode_dotl.c:300:28: warning: variable 'v9ses' set but not
> used [-Wunused-but-set-variable]
Thanks for the patch!
Eric, this appears to be for your -next tree as it doesn't build on
master -- didn't notice the [next] in the subject line until I tried...
(I've just build-checked on your tree and it appears correct there)
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>
--
Dominique
next prev parent reply other threads:[~2024-03-04 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 22:22 [PATCH][next] fs/9p: remove redundant pointer v9ses Colin Ian King
2024-03-04 12:59 ` Dominique Martinet [this message]
2024-03-15 15:34 ` Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeXFqt1NDp9sdz7n@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=colin.i.king@gmail.com \
--cc=ericvh@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox