public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: asmadeus@codewreck.org
To: ericvh@kernel.org
Cc: Lizhi Xu <lizhi.xu@windriver.com>,
	syzbot+7a3d75905ea1a830dbe5@syzkaller.appspotmail.com,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux_oss@crudebyte.com, lucho@ionkov.net,
	syzkaller-bugs@googlegroups.com, v9fs@lists.linux.dev
Subject: Re: [PATCH next] fs/9p: fix uaf in in v9fs_stat2inode_dotl
Date: Mon, 4 Mar 2024 22:02:29 +0900	[thread overview]
Message-ID: <ZeXGZS1-X8_CYCUz@codewreck.org> (raw)
In-Reply-To: <20240202121531.2550018-1-lizhi.xu@windriver.com>

Lizhi Xu wrote on Fri, Feb 02, 2024 at 08:15:31PM +0800:
> The incorrect logical order of accessing the st object code in v9fs_fid_iget_dotl
> is causing this uaf.

Thanks for the fix!

Eric, this is also for your tree.

> 
> Fixes: 724a08450f74 ("fs/9p: simplify iget to remove unnecessary paths")

(careful if you rebase your tree as this commit isn't merged yet)

> Reported-and-tested-by: syzbot+7a3d75905ea1a830dbe5@syzkaller.appspotmail.com
> Signed-off-by: Lizhi Xu <lizhi.xu@windriver.com>

Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>

-- 
Dominique Martinet | Asmadeus

  parent reply	other threads:[~2024-03-04 13:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02  4:49 [syzbot] [v9fs?] KASAN: slab-use-after-free Read in v9fs_stat2inode_dotl syzbot
2024-02-02  8:35 ` Lizhi Xu
2024-02-02  9:08   ` syzbot
2024-02-02  8:41 ` Lizhi Xu
2024-02-02 12:08   ` syzbot
2024-02-02 12:15 ` [PATCH next] fs/9p: fix uaf in " Lizhi Xu
2024-02-28 10:33   ` Breno Leitao
2024-03-04 13:02   ` asmadeus [this message]
2024-03-22  1:28     ` Jakub Kicinski
2024-03-22 14:26       ` Eric Van Hensbergen
2024-03-22 15:13         ` Jakub Kicinski
2024-03-27 18:53           ` Jakub Kicinski
2024-03-27 19:02             ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeXGZS1-X8_CYCUz@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=ericvh@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lizhi.xu@windriver.com \
    --cc=lucho@ionkov.net \
    --cc=syzbot+7a3d75905ea1a830dbe5@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=v9fs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox